Skip to content

fix(ack-pay): format errors.ts to satisfy oxfmt check#109

Merged
venables merged 1 commit into
mainfrom
fix/ack-pay-errors-format
Jun 10, 2026
Merged

fix(ack-pay): format errors.ts to satisfy oxfmt check#109
venables merged 1 commit into
mainfrom
fix/ack-pay-errors-format

Conversation

@venables

@venables venables commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Why

CI on main is red. The check:format step (oxfmt --check .) fails on packages/ack-pay/src/errors.ts:

packages/ack-pay/src/errors.ts (0ms)
Format issues found in above 1 files.
##[error]//#check:format: ... pnpm run check:format exited (1)

This was introduced in bdf929d (fix(ack-pay): preserve original error cause in verifyPaymentRequestToken), which added the options?: ErrorOptions parameter and pushed the constructor signature past oxfmt's print width without reformatting.

What

Run oxfmt on the file, wrapping the constructor parameters across multiple lines. No behavioral change.

pnpm run check:format now passes locally.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Style
    • Reformatted internal code structure for improved maintainability and readability.

Note: This release contains no user-facing changes or functional improvements.

The constructor signature exceeded the print width; wrap parameters so
`oxfmt --check` passes and unblock CI on main.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b7169238-c248-4568-81d1-5974a3535958

📥 Commits

Reviewing files that changed from the base of the PR and between bdf929d and a62eb44.

📒 Files selected for processing (1)
  • packages/ack-pay/src/errors.ts

Walkthrough

The InvalidPaymentRequestTokenError constructor in packages/ack-pay/src/errors.ts was reformatted from a single-line parameter list into multi-line format. The constructor's default message value, optional ErrorOptions parameter, function body, and public signature remain unchanged.

Changes

Error class constructor formatting

Layer / File(s) Summary
InvalidPaymentRequestTokenError constructor formatting
packages/ack-pay/src/errors.ts
Constructor parameter list reformatted to multi-line syntax. Default message and optional ErrorOptions parameter preserved; super() call and name assignment logic unchanged.

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the primary change: formatting errors.ts to resolve an oxfmt formatting check failure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/ack-pay-errors-format

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@venables venables merged commit 60eec23 into main Jun 10, 2026
3 checks passed
@venables venables deleted the fix/ack-pay-errors-format branch June 10, 2026 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant