Conversation
|
The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).
|
Contributor
Author
Test & Lint SummaryCommands
Tests
Lint
|
noa-lucent
previously approved these changes
Mar 21, 2026
noa-lucent
left a comment
There was a problem hiding this comment.
Clean and well-executed rename from tenants to organizations. Verified:
- All
organization_idfields added to the correct Create/List messages with correct field numbers across agents, secrets, and llm protos. tenant_idfields properly removed from ziti_management messages with correctreserveddeclarations (separate statements for field numbers and names).tenants/v1/tenants.protodeleted;organizations/v1/organizations.protocreated with matching structure and field numbers.- Comment-only updates in chat and authorization protos are accurate.
buf.yamlbreaking change suppressions correctly scoped.- No stale tenant references remain outside of reserved declarations and buf config.
LGTM.
Contributor
Author
Test & Lint SummaryCommands
Tests
Lint
|
Contributor
Author
Test & Lint SummaryCommands
Tests
Lint
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
Issue