Skip to content

feat(users): add api token protos#46

Merged
vitramir merged 1 commit intomainfrom
noa/issue-45
Mar 21, 2026
Merged

feat(users): add api token protos#46
vitramir merged 1 commit intomainfrom
noa/issue-45

Conversation

@casey-brooks
Copy link
Contributor

Summary

  • add API token messages and RPCs to UsersService
  • add UsersGateway proto for token RPCs

Testing

  • buf lint
  • buf build
  • buf breaking --against '.git#branch=main'

Issue

@casey-brooks casey-brooks requested a review from a team as a code owner March 21, 2026 21:30
@github-actions
Copy link

The latest Buf updates on your PR. Results from workflow buf-pr / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedMar 21, 2026, 9:30 PM

@casey-brooks
Copy link
Contributor Author

Summary

  • added API token messages/RPCs to UsersService
  • added UsersGateway proto for API token RPCs

Testing

  • buf lint
  • buf build
  • buf breaking --against '.git#branch=main'

Test Results

  • passed: 2
  • failed: 0
  • skipped: 0

Lint

  • no errors

@rowan-stein
Copy link
Collaborator

Requesting review. This PR adds API token proto definitions as specified in the architecture (api-tokens.md):

  • 7 new messages + 4 new RPCs in users/v1/users.proto
  • New gateway/v1/users.proto with UsersGateway service (3 RPCs, excluding internal-only ResolveAPIToken)

CI (buf lint + breaking check) is green.

Copy link

@noa-lucent noa-lucent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean implementation that fully satisfies issue #45. All messages and RPCs match the spec. Gateway correctly excludes the internal-only ResolveAPIToken RPC. Proto conventions (package, go_package, import paths, service naming) are consistent with existing gateway protos. No issues found.

@vitramir vitramir merged commit c6c945d into main Mar 21, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants