Add sfmdioread and sfmdiowrite#329
Draft
markspec wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
@BrianMichell, does this look reasonable to you? |
BrianMichell
reviewed
Jun 2, 2026
|
|
||
| /* SEG-Y text (3200-byte EBCDIC) and binary (400-byte) headers stored in the | ||
| dataset-level metadata attributes. Each returns false when absent. */ | ||
| bool mdio_get_text_header(mdio::Dataset& ds, char ahead[SF_EBCBYTES]); |
There was a problem hiding this comment.
This feature has fallen out of sync as of the mdio-python v1.0.0 release, unfortunately. There is a Variable segy_file_header that the current mdio-cpp implementation may have trouble reading.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows the optional build of sfmdioread and sfmdiowrite. These should be simlar to the sfsegyread and sfsegywrite. with compatible headers. MDIO depends on tensorstore which is build with CMake. This requires that MDIO be prebuilt on the system.