Skip to content

fix(pegged-dao): S7 phase ratchet + 23 new security tests #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
secret-mars wants to merge 2 commits into
base: feat/pegged-dao-v2-no-guardians
Choose a base branch
from
Open

fix(pegged-dao): S7 phase ratchet + 23 new security tests #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
118c589
fix(pegged-dao): S7 one-way phase ratchet + 23 new security tests
secret-mars Mar 10, 2026
03157bd
pegged-dao: document set-phase ratchet irreversibility + upgrade path
secret-mars Apr 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions contracts/pegged/dao-pegged.clar
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,10 +71,26 @@
;; ============================================================

;; Advance to Phase 2 (called by upgrade-to-free-floating on successful vote)
;; S7: one-way ratchet - phase can only increase, never revert.
;;
;; DESIGN NOTE (irreversibility is intentional):
;; There is NO break-glass mechanism. Not even the DAO itself can roll back
;; a phase transition via governance proposal - the (> new-phase current)
;; assertion blocks any revert regardless of caller. This is a deliberate
;; safety guarantee: Phase 2 unlocks features that were intentionally
;; disabled in Phase 1 (peg exit, free-floating dynamics). Allowing revert
;; would let a malicious or compromised DAO extension re-enter Phase 1 to
;; abuse features that were supposed to be locked.
;;
;; Upgrade path for Phase 2 bugs: deploy a new pegged-dao contract and
;; migrate treasury/state via a governance-approved one-time migration
;; extension. NOT a phase-revert. This keeps the ratchet invariant intact
;; across the contract's lifetime.
(define-public (set-phase (new-phase uint))
(begin
(try! (is-dao-or-extension))
(asserts! (or (is-eq new-phase u1) (is-eq new-phase u2)) ERR_NOT_AUTHORIZED)
(asserts! (> new-phase (var-get phase)) ERR_NOT_AUTHORIZED)
(var-set phase new-phase)
(print {
notification: "dao-pegged/phase-change",
Expand Down
Loading