fix(test): add cell_detection parquet files to HETA e2e expected results#669
Closed
olivermeyer wants to merge 1 commit into
Closed
fix(test): add cell_detection parquet files to HETA e2e expected results#669olivermeyer wants to merge 1 commit into
olivermeyer wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Pull request overview
Updates the HETA (he-tme) end-to-end test expectations to account for two newly produced parquet artifacts so the existing CLI/GUI e2e assertions on result contents and file sizes remain aligned with current application outputs.
Changes:
- Add
cell_detection_parquet_polygons.parquetto the expected result file lists for SPOT_0 and SPOT_1. - Add
cell_detection_parquet_centers.parquetto the expected result file lists for SPOT_0 and SPOT_1. - Record expected byte sizes (and tolerances) for both new artifacts.
2a3275a to
4a5cdac
Compare
❌ 1 Tests Failed:
View the full list of 1 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
4a5cdac to
08f1466
Compare
08f1466 to
edc01a6
Compare
|
Comment on lines
+103
to
+106
| ("tissue_qc_parquet_polygons.parquet", 39435, 10), | ||
| ("tissue_segmentation_parquet_polygons.parquet", 117509, 10), | ||
| ("cell_classification_parquet_polygons.parquet", 1985592, 10), | ||
| ] |
Comment on lines
+117
to
+120
| ("tissue_qc_parquet_polygons.parquet", 29087, 10), | ||
| ("tissue_segmentation_parquet_polygons.parquet", 56563, 10), | ||
| ("cell_classification_parquet_polygons.parquet", 562536, 10), | ||
| ] |
Comment on lines
70
to
74
| # These defaults reflect the production he-tme run. If staging produces different output (e.g. | ||
| # after deploying a new application version to staging before production), add an override inside | ||
| # the "staging" case below — only the constants that actually differ need to be reassigned. | ||
| # Note: defined here rather than inside each match arm to avoid SonarCloud flagging the | ||
| # nearly-identical blocks as duplicated code (the 3% duplication threshold). |
Comment on lines
+137
to
+141
| SPOT_0_EXPECTED_RESULT_FILES = [ | ||
| ("tissue_qc_segmentation_map_image.tiff", 1645652, 10), | ||
| ("tissue_qc_geojson_polygons.json", 101150, 10), | ||
| ("tissue_segmentation_geojson_polygons.json", 327625, 10), | ||
| ("readout_generation_slide_readouts.csv", 303585, 10), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Why?
Staging now runs HETA 1.2.0 which produces two additional parquet output files (
cell_detection_parquet_polygons.parquetandcell_detection_parquet_centers.parquet) that production does not yet emit. Having a single shared expected-results list made it impossible to assert the correct file set per environment.How?
Moved
SPOT_0_EXPECTED_RESULT_FILESandSPOT_1_EXPECTED_RESULT_FILESfrom top-level defaults into their respectiveproductionandstagingmatch arms so each environment can declare its own expected artifacts. The staging lists include the two new cell detection parquet files; the production lists remain unchanged.