feat(check-stream): support configurable stream names#1030
feat(check-stream): support configurable stream names#1030devin-ai-integration[bot] wants to merge 2 commits into
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
👋 Greetings, Airbyte Team Member!Here are some helpful tips and reminders for your convenience. 💡 Show Tips and TricksTesting This CDK VersionYou can test this version of the CDK using the following: # Run the CLI from this branch:
uvx 'git+https://github.com/airbytehq/airbyte-python-cdk.git@devin/1779315328-configurable-check-streams#egg=airbyte-python-cdk[dev]' --help
# Update a connector to use the CDK from this branch ref:
cd airbyte-integrations/connectors/source-example
poe use-cdk-branch devin/1779315328-configurable-check-streamsPR Slash CommandsAirbyte Maintainers can execute the following slash commands on your PR:
|
|
CI note: the only current failed check is optional Failure detailsThe failed job is https://github.com/airbytehq/airbyte-python-cdk/actions/runs/26193981254/job/77069032809. It failed in an existing JWT test, not in the changed check-stream tests: The same full pytest matrix passed on Targeted local verification still passes for this PR's changed area: The failing JWT assertion appears unrelated to this PR's two touched files ( |
|
Updated the local variable in Re-ran targeted checks successfully: |
|
Description updated to include the mypy check that was run after the rename. |
Summary
Adds support for overriding declarative
CheckStreamstream names from connector config using the top-levelairbyte_check_stream_nameskey. When the key is absent, existing manifeststream_namesbehavior is preserved; when present, the value must be a list of strings and the selected names still go through the existing catalog membership and availability checks.Review & Testing Checklist for Human
airbyte_check_stream_namesis the intended platform-facing config key for ADP/Sonar integration.stream_namesincludes an unselected stream and whose source config provides selected stream names throughairbyte_check_stream_names.Notes
Local checks run:
poetry run ruff format --check airbyte_cdk/sources/declarative/checks/check_stream.py unit_tests/sources/declarative/checks/test_check_stream.pypoetry run ruff check airbyte_cdk/sources/declarative/checks/check_stream.py unit_tests/sources/declarative/checks/test_check_stream.pypoetry run mypy --config-file mypy.ini airbyte_cdk/sources/declarative/checks/check_stream.pypoetry run pytest unit_tests/sources/declarative/checks/test_check_stream.py -qLink to Devin session: https://app.devin.ai/sessions/2fe0f6c5174b40a1842828a49e32f69b