test: add regression for reentrant fetchMore on resultsInserted#13
Open
brenns10 wants to merge 1 commit intoalbertlauncher:mainfrom
Open
test: add regression for reentrant fetchMore on resultsInserted#13brenns10 wants to merge 1 commit intoalbertlauncher:mainfrom
brenns10 wants to merge 1 commit intoalbertlauncher:mainfrom
Conversation
Add a query execution test that connects QueryResults::resultsInserted to exec->fetchMore(), mirroring frontend model behavior. Assert that a GeneratorQueryHandler delivering multiple chunks reaches the final count and canFetchMore()==false. This test fails without the GeneratorQueryHandler fix in albert core. Refs: albertlauncher#12
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a test which verifies that multi-chunk handlers get all of their results consumed. It verifies the fix in albertlauncher/albert#1618. Without that fix, the test stalls and then fails. With it, the test passes.