Skip to content

setup eslint #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
admclamb wants to merge 1 commit into
base: master
Choose a base branch
from
Open

setup eslint #3

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 52 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
name: CI

on:
push:
branches: [master]
pull_request:
branches: [master]

jobs:
build:
runs-on: ubuntu-latest

strategy:
matrix:
node-version: [24.x]

env:
AUTH0_SECRET: ${{ secrets.AUTH0_SECRET }}
APP_BASE_URL: ${{ secrets.APP_BASE_URL }}
AUTH0_DOMAIN: ${{ secrets.AUTH0_DOMAIN }}
AUTH0_CLIENT_ID: ${{ secrets.AUTH0_CLIENT_ID }}
AUTH0_CLIENT_SECRET: ${{ secrets.AUTH0_CLIENT_SECRET }}
DATABASE_URL: ${{ secrets.DATABASE_URL }}

steps:
- uses: actions/checkout@v6

- name: Install pnpm
uses: pnpm/action-setup@fc06bc1257f339d1d5d8b3a19a8cae5388b55320
with:
version: 10.27.0

- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
cache: 'pnpm'

- name: Install dependencies
run: pnpm install --frozen-lockfile

- name: Run lint
run: pnpm lint

- name: Run typecheck
run: pnpm typecheck

- name: Check code format
run: pnpm format:check

- name: Build app
run: pnpm build
48 changes: 36 additions & 12 deletions eslint.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,19 @@
// @ts-check
const eslint = require('@eslint/js');
const { defineConfig } = require('eslint/config');
const tseslint = require('typescript-eslint');
const angular = require('angular-eslint');

module.exports = defineConfig([
module.exports = tseslint.config(
{
files: ['**/*.ts'],
extends: [
eslint.configs.recommended,
tseslint.configs.recommended,
tseslint.configs.stylistic,
angular.configs.tsRecommended,
'plugin:@angular-eslint/recommended',
'plugin:prettier/recommended',
...tseslint.configs.recommended,
...tseslint.configs.stylistic,
...angular.configs.tsRecommended,
],
processor: angular.processInlineTemplates,
rules: {
'@angular-eslint/component-class-suffix': 'off',
'@angular-eslint/directive-selector': [
'error',
{
Expand All @@ -33,12 +30,39 @@ module.exports = defineConfig([
style: 'kebab-case',
},
],
'prettier/prettier': 'error',
'@typescript-eslint/explicit-member-accessibility': 'error',
'@typescript-eslint/explicit-function-return-type': [
'error',
{
allowExpressions: true,
},
],
'@typescript-eslint/no-empty-function': 'error',
'@typescript-eslint/no-explicit-any': 'error',
'@typescript-eslint/no-unused-vars': 'error',
'@typescript-eslint/no-inferrable-types': 'off',
'@typescript-eslint/typedef': [
'error',
{
memberVariableDeclaration: true,
propertyDeclaration: false,
parameter: true,
variableDeclaration: false,
arrowParameter: false,
},
],
'no-console': 'warn',
},
},
{
files: ['**/*.html'],
extends: [angular.configs.templateRecommended, angular.configs.templateAccessibility],
rules: {},
extends: [...angular.configs.templateRecommended, ...angular.configs.templateAccessibility],
rules: {
'@angular-eslint/template/alt-text': 'error',
'@angular-eslint/template/elements-content': 'error',
'@angular-eslint/template/label-has-associated-control': 'error',
'@angular-eslint/template/table-scope': 'error',
'@angular-eslint/template/valid-aria': 'error',
},
},
]);
);
122 changes: 61 additions & 61 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,63 +1,63 @@
{
"name": "admin-web",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"watch": "ng build --watch --configuration development",
"test": "ng test",
"lint": "ng lint",
"format": "prettier --write .",
"format:check": "prettier --check ."
},
"prettier": {
"printWidth": 100,
"singleQuote": true,
"overrides": [
{
"files": "*.html",
"options": {
"parser": "angular"
}
}
]
},
"private": true,
"packageManager": "pnpm@10.27.0",
"dependencies": {
"@angular-architects/ngrx-toolkit": "^21.0.1",
"@angular/common": "^21.1.0",
"@angular/compiler": "^21.1.0",
"@angular/core": "^21.1.0",
"@angular/forms": "^21.1.0",
"@angular/platform-browser": "^21.1.0",
"@angular/router": "^21.1.0",
"@auth0/auth0-angular": "^2.8.0",
"@ngrx/signals": "^21.1.0",
"@primeuix/themes": "^2.0.3",
"primeicons": "^7.0.0",
"primeng": "^21.1.6",
"rxjs": "~7.8.0",
"tailwindcss-primeui": "^0.6.1",
"tslib": "^2.3.0"
},
"devDependencies": {
"@angular-eslint/builder": "21.4.0",
"@angular/build": "^21.1.2",
"@angular/cli": "^21.1.2",
"@angular/compiler-cli": "^21.1.0",
"@eslint/js": "^10.0.1",
"@ngx-env/builder": "^21.0.1",
"@tailwindcss/postcss": "^4.1.12",
"angular-eslint": "21.4.0",
"eslint": "^10.3.0",
"jsdom": "^27.1.0",
"postcss": "^8.5.3",
"prettier": "3.8.3",
"tailwindcss": "^4.1.12",
"typescript": "~5.9.2",
"typescript-eslint": "8.59.2",
"vitest": "^4.0.8"
}
"name": "admin-web",
"version": "0.0.0",
"scripts": {
"ng": "ng",
"start": "ng serve",
"build": "ng build",
"watch": "ng build --watch --configuration development",
"test": "ng test",
"lint": "ng lint",
"format": "prettier --write .",
"format:check": "prettier --check ."
},
"prettier": {
"printWidth": 100,
"singleQuote": true,
"overrides": [
{
"files": "*.html",
"options": {
"parser": "angular"
}
}
]
},
"private": true,
"packageManager": "pnpm@10.27.0",
"dependencies": {
"@angular-architects/ngrx-toolkit": "^21.0.1",
"@angular/common": "^21.1.0",
"@angular/compiler": "^21.1.0",
"@angular/core": "^21.1.0",
"@angular/forms": "^21.1.0",
"@angular/platform-browser": "^21.1.0",
"@angular/router": "^21.1.0",
"@auth0/auth0-angular": "^2.8.0",
"@ngrx/signals": "^21.1.0",
"@primeuix/themes": "^2.0.3",
"primeicons": "^7.0.0",
"primeng": "^21.1.6",
"rxjs": "~7.8.0",
"tailwindcss-primeui": "^0.6.1",
"tslib": "^2.3.0"
},
"devDependencies": {
"@angular-eslint/builder": "21.4.0",
"@angular/build": "^21.1.2",
"@angular/cli": "^21.1.2",
"@angular/compiler-cli": "^21.1.0",
"@eslint/js": "^10.0.1",
"@ngx-env/builder": "^21.0.1",
"@tailwindcss/postcss": "^4.1.12",
"angular-eslint": "21.4.0",
"eslint": "^10.3.0",
"jsdom": "^27.1.0",
"postcss": "^8.5.3",
"prettier": "3.8.3",
"tailwindcss": "^4.1.12",
"typescript": "~5.9.2",
"typescript-eslint": "8.59.2",
"vitest": "^4.0.8"
}
}
9 changes: 0 additions & 9 deletions pnpm-lock.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions src/env.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable @typescript-eslint/naming-convention */
// Define the type of the environment variables.
declare interface Env {
readonly NODE_ENV: string;
Expand Down
1 change: 1 addition & 0 deletions src/environments/environment.development.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable @typescript-eslint/naming-convention */
export const environment = {
production: false,
apiServerUrl: import.meta.env['NG_APP_API_SERVER_URL'],
Expand Down
1 change: 1 addition & 0 deletions src/environments/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable @typescript-eslint/naming-convention */
export const environment = {
production: true,
apiServerUrl: import.meta.env['NG_APP_API_SERVER_URL'],
Expand Down