remove run button#33
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the “Run” action from the Problem page’s action bar, leaving only “Submit” and “View Submissions”, and updates the associated unit tests accordingly.
Changes:
- Removed the Run button and its handler from
ProblemActions. - Updated
ProblemActionstests to stop asserting Run-related behavior and to reflect the new UI structure.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/features/problem/problem-actions/problem-actions.tsx | Removes Run UI/handler; leaves Submit + View Submissions. |
| src/features/problem/problem-actions/problem-actions.test.tsx | Removes Run-related test cases and updates list-item/lock-icon assertions. |
Comments suppressed due to low confidence (1)
src/features/problem/problem-actions/problem-actions.test.tsx:141
- In this test,
createSubmission(used byuseCreateSubmission) returns astring, but the mock resolves to an object ({ submissionId: "123" }). Also, the component callssetActiveSubmissionId(id)after the mutation resolves, so the mocked store state needs to include asetActiveSubmissionIdfunction (and ideally assert it was called with the returned string) to avoid runtime errors during the click.
it("calls submitSubmissionMutation when Submit button is clicked", async () => {
setupMocks();
mockSubmitMutateAsync.mockResolvedValue({ submissionId: "123" });
const user = userEvent.setup();
Comment on lines
30
to
32
| const runSubmissionMutation = useRunSubmission(); | ||
| const submitSubmissionMutation = useCreateSubmission(); | ||
|
|
Comment on lines
55
to
57
| <li> | ||
| <Button | ||
| className="w-24" |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.