support custom traffic shaping controller#3477
Conversation
uuuyuqi
left a comment
There was a problem hiding this comment.
Nice work. By the way, could you add some unit tests? The new version of ci does have coverage checks
Hi @icodening , thank you so much for this PR — I think your implementation idea is really great! Thanks again for your work! |
|
#3567 Hi,@uuuyuqi — when you have time, please help take a look at this PR. |
|
We'll continue discussing this issue in PR #3567. |
Describe what this PR does / why we need it
support custom traffic shaping controller
Does this pull request fix one issue?
ref #3189
Describe how you did it
using
TrafficShapingControllerFactoryspi to create instanceDescribe how to verify it
Special notes for reviews