test(stability): add query benchmarks + a concurrent read/write test#69
Open
qiansheng91 wants to merge 1 commit into
Open
test(stability): add query benchmarks + a concurrent read/write test#69qiansheng91 wants to merge 1 commit into
qiansheng91 wants to merge 1 commit into
Conversation
Benchmarks (internal/graphstore, internal/query) for the hot read paths — QueryEntities, QueryTopo, and the full Service.Execute entity path — so perf regressions on large result sets become visible. 'make bench' runs them (smoke by default, BENCHTIME-overridable); CI runs them non-blocking. A concurrent read/write test stresses the memory store's RWMutex; under 'go test -race' it is a data-race regression guard for the shared maps (verified race-clean).
Mr-Xzz
approved these changes
Jun 18, 2026
Mr-Xzz
left a comment
Mr-Xzz
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed the benchmark smoke target and concurrent read/write test. The CI step is non-blocking and the new test exercises the in-memory store locking path without broadening runtime behavior. No blocking findings from my pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No performance or concurrency coverage existed for the read path.
QueryEntities/QueryTopoand the query executor.make benchsmoke step in CI.Verification: benchmarks run; the concurrent test passes under
-race.