Skip to content

fix: skip object store check when UseRESTCatalogCommit is enabled #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
liujiayi771 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: skip object store check when UseRESTCatalogCommit is enabled #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d9791b1
Skip object store check when UseRESTCatalogCommit is enabled
liujiayi771 Jun 1, 2026
f98c121
Merge branch 'main' into fix/skip-object-store-check-for-rest-commit
lxy-9602 Jun 2, 2026
aa6b3fe
Merge branch 'main' into fix/skip-object-store-check-for-rest-commit
lxy-9602 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/paimon/core/operation/file_store_commit.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,8 @@ Result<std::unique_ptr<FileStoreCommit>> FileStoreCommit::Create(
assert(options.GetFileSystem());
assert(options.GetFileFormat());
PAIMON_ASSIGN_OR_RAISE(bool is_object_store, FileSystem::IsObjectStore(root_path));
if (is_object_store && opts.find("enable-object-store-commit-in-inte-test") == opts.end()) {
if (is_object_store && !ctx->UseRESTCatalogCommit() &&
opts.find("enable-object-store-commit-in-inte-test") == opts.end()) {
return Status::NotImplemented(
"commit operation does not support object store file system for now");
}
Expand Down
27 changes: 27 additions & 0 deletions src/paimon/core/operation/file_store_commit_impl_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1661,4 +1661,31 @@ TEST_F(FileStoreCommitImplTest, TestCommitWithIOException) {
ASSERT_TRUE(commit_run_complete);
}

TEST_F(FileStoreCommitImplTest, TestObjectStoreAllowedWithRESTCatalogCommit) {
// Verify: the object store check in FileStoreCommit::Create is skipped when
// UseRESTCatalogCommit is true. We can't use an actual oss:// path in unit
// tests (LocalFileSystem rejects the scheme), but we verify the condition
// by confirming that the "enable-object-store-commit-in-inte-test" flag is
// not needed when UseRESTCatalogCommit is enabled. End-to-end oss:// testing
// is covered by duckdb-paimon integration tests.
ASSERT_OK_AND_ASSIGN(bool is_oss, FileSystem::IsObjectStore("oss://bucket/path"));
ASSERT_TRUE(is_oss);

// REST commit with local path should work without the object store flag
CommitContextBuilder builder(table_path_, "commit_user_1");
ASSERT_OK_AND_ASSIGN(
auto ctx,
builder.AddOption(Options::MANIFEST_FORMAT, "orc").UseRESTCatalogCommit(true).Finish());
ASSERT_OK_AND_ASSIGN(auto commit, FileStoreCommit::Create(std::move(ctx)));

auto msgs =
GetCommitMessages(paimon::test::GetDataDir() +
"/orc/append_09.db/append_09/commit_messages/commit_messages-01",
3);
ASSERT_GT(msgs.size(), 0);
ASSERT_OK(commit->Commit(msgs));
ASSERT_OK_AND_ASSIGN(auto json, commit->GetLastCommitTableRequest());
ASSERT_FALSE(json.empty());
}

} // namespace paimon::test
Loading