Skip to content

feat: remove support for FLOAT/DOUBLE type partition field#333

Open
lszskye wants to merge 3 commits into
alibaba:mainfrom
lszskye:fix_apache_38
Open

feat: remove support for FLOAT/DOUBLE type partition field#333
lszskye wants to merge 3 commits into
alibaba:mainfrom
lszskye:fix_apache_38

Conversation

@lszskye
Copy link
Copy Markdown
Collaborator

@lszskye lszskye commented Jun 3, 2026

Purpose

remove support for FLOAT/DOUBLE type partition field

Copy link
Copy Markdown
Collaborator

@lucasfang lucasfang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Copy Markdown
Collaborator

@zjw1111 zjw1111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requesting changes for one scope issue:

  • src/paimon/testing/utils/data_generator.cpp: removing FLOAT / DOUBLE support from DataGenerator::WriteBinaryRow also affects bucket-row construction, not only partition-row construction. SplitArrayByPartitionAndBucket() uses the same ExtractPartialRow(binary_row, bucket_fields) path to build bucket_row for bucket id calculation. The schema validation added in this PR only rejects FLOAT / DOUBLE partition keys, while FLOAT / DOUBLE bucket keys are still allowed and the production BucketIdCalculator::WriteBucketRow still supports them. As a result, a legal table with a FLOAT / DOUBLE bucket key that is not a partition key can become unsupported in the test data generation path. Please keep the FLOAT / DOUBLE branches in DataGenerator::WriteBinaryRow, or split the helper so the new restriction applies only to the partition converter / schema validation path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants