fix: fix unstable prefetch reader case#336
Open
lucasfang wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: stabilize prefetch SetReadRanges failure test
Purpose
Linked issue: N/A
Stabilize
PrefetchFileBatchReaderImplTest.SetReadRangesReturnErrorWhenPushDownFailedby making the injectedSetReadRangesfailure independent of concurrent reader build order.Previously the test used one OK status and one IOError status for mock readers. Since readers are built concurrently, the failure injection depended on thread scheduling and could become flaky. This change injects IOError into both mock readers so the test deterministically verifies that
PrefetchFileBatchReaderImpl::SetReadRangespropagates pushdown failures.Tests
./build/debug/paimon-common-test --gtest_filter=PrefetchFileBatchReaderImplTest.SetReadRangesReturnErrorWhenPushDownFailedPASSED 100/100src/paimon/common/reader/prefetch_file_batch_reader_impl_test.cpp: no lint errors foundAPI and Format
No API, storage format, or protocol changes.
Documentation
No user-facing feature or documentation changes.
Generative AI tooling
Generated-by: Aone Copilot ide-idealab/gpt-5.5