Allow FileStoreCommit for PK tables with postpone bucket mode#337
Open
liujiayi771 wants to merge 1 commit into
Open
Allow FileStoreCommit for PK tables with postpone bucket mode#337liujiayi771 wants to merge 1 commit into
liujiayi771 wants to merge 1 commit into
Conversation
Postpone bucket mode (bucket=-2) writes data like an append table: all files go to bucket--2/ directory and the REST catalog server handles bucket redistribution during background compaction. The commit logic (manifest and snapshot generation) is identical to append tables, so there is no reason to block it. See: https://paimon.apache.org/docs/master/primary-key-table/data-distribution/#postpone-bucket Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileStoreCommit::Createto proceed for PK tables when using postpone bucket mode (bucket=-2)bucket-postponedirectory of each partition and are not available to readers. To move the records into the correct bucket and make them readable, a compaction job needs to be run (viacompactprocedure or triggered by the catalog server)bucket > 0) remain blocked as beforeTest plan
TestPostponeBucketPKTableCommitAllowed: PK table withbucket=-2→FileStoreCommit::Createsucceeds without workaround flagTestFixedBucketPKTableCommitRejected: PK table withbucket=4→FileStoreCommit::CreatereturnsNotImplementedReference