[Aikido] Fix 2 security issues in ajv, minimatch#1615
Closed
aikido-autofix[bot] wants to merge 1 commit intomainfrom
Closed
[Aikido] Fix 2 security issues in ajv, minimatch#1615aikido-autofix[bot] wants to merge 1 commit intomainfrom
aikido-autofix[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade ajv and minimatch to mitigate ReDoS vulnerabilities that can cause catastrophic regex backtracking and potential denial of service attacks.
✅ Code not affected by breaking changes.
No breaking changes from the minimatch upgrade (3.1.2 => 10.2.1) affect this codebase.
While
minimatchis present as a transitive dependency through ESLint and other tools (visible inyarn.lock), and is explicitly set in theresolutionssection ofpackage.jsonto version10.2.1, the codebase does not directly import or use minimatch. The only indirect usage is through ESLint'signorePatternsin.eslintrc.json, which uses simple glob patterns (**/node_modules/**,**/dist/**, etc.) that are fully compatible with all versions of minimatch and are not affected by any of the breaking changes (forward slash requirement,..preprocessing, default export removal, or Node.js version requirements).All breaking changes by upgrading minimatch from version 3.1.2 to 10.2.1 (CHANGELOG)
..pattern portions where possible. Note that this means a pattern likea/b/../*will be equivalent toa/*, and will not match the stringa/b/../c✅ 2 CVEs resolved by this upgrade
This PR will resolve the following CVEs: