[WHIT-2990] Remove single image from news article schema#3933
Merged
lauraghiorghisor-tw merged 2 commits intomainfrom Mar 18, 2026
Merged
[WHIT-2990] Remove single image from news article schema#3933lauraghiorghisor-tw merged 2 commits intomainfrom
lauraghiorghisor-tw merged 2 commits intomainfrom
Conversation
lauraghiorghisor-tw
changed the title
lauraghiorghisor-tw
force-pushed
the
contract-news-articles
branch
from
665c05a to
1d474ae
Compare
lauraghiorghisor-tw
force-pushed
the
contract-news-articles
branch
3 times, most recently
from
45aa829 to
bae02db
Compare
| uses: alphagov/frontend/.github/workflows/rspec.yml@main | ||
| with: | ||
| ref: 'main' | ||
| ref: 'contract-news-articles' |
Contributor
Author
There was a problem hiding this comment.
I tried everything else first 😅 It's the only way.
This was referenced Mar 17, 2026
| { | ||
| "type": "lead", | ||
| "sources": { | ||
| "s960": "https://assets.publishing.service.gov.uk/government/uploads/system/uploads/image_data/file/41447/s960_PTN-D1322-115_960x640.jpg", |
Contributor
Author
There was a problem hiding this comment.
Now, it would be nice if we had these down as media/:id urls rather than legacy path urls... but that can be its own work at a later point. Also noting that most of the examples have alt text which is not currently something we send from whitehall anymore (but it is allowed in the schema, so technically fine here).
ryanb-gds
approved these changes
Mar 18, 2026
Contributor
ryanb-gds
left a comment
ryanb-gds
left a comment
There was a problem hiding this comment.
Thanks for adding the examples
Use details.images with sources and type. Also update examples to match the schema.
lauraghiorghisor-tw
force-pushed
the
contract-news-articles
branch
from
bae02db to
54d9aad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows on from #3890.
Jira