Add list, symbol/annotation SID, single-char symbol opcode handlers #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## ion11 #1140 +/- ##
========================================
Coverage ? 69.68%
Complexity ? 6396
========================================
Files ? 207
Lines ? 25928
Branches ? 4489
========================================
Hits ? 18068
Misses ? 6473
Partials ? 1387 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
popematt
reviewed
Nov 5, 2025
src/test/java/com/amazon/ion/bytecode/bin11/bytearray/ListOpcodeHandlerTests.kt
Outdated
Show resolved
Hide resolved
src/test/java/com/amazon/ion/bytecode/bin11/bytearray/ListOpcodeHandlerTests.kt
Show resolved
Hide resolved
src/test/java/com/amazon/ion/bytecode/bin11/bytearray/ListOpcodeHandlerTests.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/ion/bytecode/bin11/bytearray/AnnotationSIDOpcodeHandler.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/ion/bytecode/bin11/bytearray/IntOpcodeHandlers.kt
Show resolved
Hide resolved
src/main/java/com/amazon/ion/bytecode/bin11/bytearray/ListOpcodeHandlers.kt
Outdated
Show resolved
Hide resolved
src/main/java/com/amazon/ion/bytecode/bin11/bytearray/ListOpcodeHandlers.kt
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew Pope <81593196+popematt@users.noreply.github.com>
Co-authored-by: Matthew Pope <81593196+popematt@users.noreply.github.com>
Co-authored-by: Matthew Pope <81593196+popematt@users.noreply.github.com>
Co-authored-by: Matthew Pope <81593196+popematt@users.noreply.github.com>
Co-authored-by: Matthew Pope <81593196+popematt@users.noreply.github.com>
tgregg
reviewed
Nov 5, 2025
src/main/java/com/amazon/ion/bytecode/bin11/ByteArrayBytecodeGenerator11.kt
Show resolved
Hide resolved
popematt
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This PR adds 1.1 binary bytecode generator handlers for a handful of opcodes, mostly lists. Added are handlers for:
0xB0-0xBF0xFA0xF00x5B0x580x50-0x570xA1By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.