fix redefine error when enabling aiebu#1051
fix redefine error when enabling aiebu#1051HimanshuChoudhary-Xilinx wants to merge 2 commits intoamd:mainfrom
Conversation
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
Signed-off-by: Himanshu Choudhary <Himanshu.Choudhary@amd.com>
There was a problem hiding this comment.
Pull request overview
This PR fixes a redefine error when enabling AIEBU by removing the redundant DOPENCL_ICD_LOADER compile option and updating the XRT submodule reference.
Changes:
- Removed
-DOPENCL_ICD_LOADERfrom compile options inCMake/xrt_ve2.cmake - Updated XRT submodule commit hash
- Updated XRT submodule URL to point to a different GitHub repository
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| CMake/xrt_ve2.cmake | Removed -DOPENCL_ICD_LOADER compile option to fix redefine error |
| xrt | Updated submodule commit hash to include the fix |
| .gitmodules | Changed XRT submodule URL to HimanshuChoudhary-Xilinx fork |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [submodule "xrt"] | ||
| path = xrt | ||
| url = https://github.com/Xilinx/XRT.git | ||
| url = https://github.com/HimanshuChoudhary-Xilinx/XRT.git |
There was a problem hiding this comment.
The submodule URL has been changed from the official Xilinx/XRT repository to a personal fork (HimanshuChoudhary-Xilinx/XRT). Using a personal fork instead of the official repository can cause maintainability issues and may not receive official updates. Consider upstreaming the necessary changes to the official repository or documenting why this fork is required.
| url = https://github.com/HimanshuChoudhary-Xilinx/XRT.git | |
| url = https://github.com/Xilinx/XRT.git |
|
retest this please |
No description provided.