Added vu11p NYX dts#3072
Added vu11p NYX dts#3072gastmaier merged 3 commits intoanalogdevicesinc:staging/xlnx/main-next-ad9084-devfrom
Conversation
|
@tfcollins Opened PR for Nyx DTS |
|
Hi @omaganap please fix the checkpatch warnings raised in the ci |
|
Also, please add the overly in the proper directory rather than the top leval... |
2e60b4f to
6ad0b7f
Compare
7b4bc02 to
93ebb32
Compare
|
@gastmaier , @nunojsa , I made the fixes and I added new files. Let me know if there is anything else I need to change. |
b7e82ea to
eb02d81
Compare
Add vu11p NYX dts and device tree for nyx personality card Add new device tree file for vu11p for profile 204C_M4_L4_NP16_8p0_2x2 Signed-off-by: Oscar Magana Pantoja <Oscar.MaganaPantoja@analog.com>
Sorry I missed the other file I added. I also fixed the white spaces on arch/arm64/boot/dts/xilinx/vu11p-ad9084-vpx-revb.dtso since that's the one I copied the bulk of the code. |
|
It also seems CI is not passing |
Yea I looked through that check but I think the errors are in the logs are primarily related to files under arch/microblaze/boot/dts/ such as vcu118_quad_ad9081.dtsi and related dts files. Not from my changes. Maybe the CI needs to be updated/fixed? |
|
Looking into the cause of the compile dts failure, not sure if caused by |
The dts does not compile isolated, it is a template for multiple parameters. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
The dts does not compile isolated, it is a template for multiple parameters. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
|
Ok gotcha, starting on apollo we have template dts, that error out by themself. Since we have markers like I will extend as an alternative to aka Yes, NOTE: We currently are not globbing |
| * | ||
| * hdl_project: <ad9084_fmca_ebz/vcu118> | ||
| * board_revision: <> | ||
| * is_template: true |
There was a problem hiding this comment.
I feel this is a big hack! Looking at the commit message:
"The dts does not compile isolated, it is a template for multiple
parameters."
AFAIK, a .dts must compile. If it's not compiling then we're doing something wrong and this feels like papering around it.
6a6701f
into
analogdevicesinc:staging/xlnx/main-next-ad9084-dev
Again, I do not think this can happen. Fine this is merged on a dev branch but I do expect we fix this out before merging into main. Unless I'm missing something... |
|
Sorry, i merged without seeing this comment, should we rename them as |
|
This is an alternative to the The use case is to have a "master" devicetree and children that just tune the values, like this one Let me know your preference:
|
It depends, if this is just about some different configuration, I think a .dts including a .dts is fine. I think that what needs to be done is that the main/base .dts needs to compile (so it likely needs some fixing) and the extensions just change the bits they need for their usecase. So without knowing too much detail on what is going one, at first glance, this does not look like a CI problem to me. For reference on style: |
PR Description
necessary to understand them. List any dependencies required for this change.
any space), or simply check them after publishing the PR.
description and try to push all related PRs simultaneously.
PR Type
PR Checklist