Skip to content

Added vu11p NYX dts#3072

Merged
gastmaier merged 3 commits intoanalogdevicesinc:staging/xlnx/main-next-ad9084-devfrom
omaganap:staging/xlnx/main-next-ad9084-dev
Jan 26, 2026
Merged

Added vu11p NYX dts#3072
gastmaier merged 3 commits intoanalogdevicesinc:staging/xlnx/main-next-ad9084-devfrom
omaganap:staging/xlnx/main-next-ad9084-dev

Conversation

@omaganap
Copy link
Copy Markdown

@omaganap omaganap commented Jan 9, 2026

PR Description

  • Please replace this comment with a summary of your changes, and add any context
    necessary to understand them. List any dependencies required for this change.
  • To check the checkboxes below, insert a 'x' between square brackets (without
    any space), or simply check them after publishing the PR.
  • If you changes include a breaking change, please specify dependent PRs in the
    description and try to push all related PRs simultaneously.

PR Type

  • Bug fix (a change that fixes an issue)
  • New feature (a change that adds new functionality)
  • Breaking change (a change that affects other repos or cause CIs to fail)

PR Checklist

  • I have conducted a self-review of my own code changes
  • I have compiled my changes, including the documentation
  • I have tested the changes on the relevant hardware
  • I have updated the documentation outside this repo accordingly
  • I have provided links for the relevant upstream lore

@omaganap
Copy link
Copy Markdown
Author

omaganap commented Jan 9, 2026

@tfcollins Opened PR for Nyx DTS

@gastmaier
Copy link
Copy Markdown
Collaborator

Hi @omaganap please fix the checkpatch warnings raised in the ci

@nunojsa
Copy link
Copy Markdown
Collaborator

nunojsa commented Jan 14, 2026

Also, please add the overly in the proper directory rather than the top leval...

@omaganap omaganap force-pushed the staging/xlnx/main-next-ad9084-dev branch from 2e60b4f to 6ad0b7f Compare January 20, 2026 20:46
@omaganap omaganap marked this pull request as draft January 20, 2026 20:51
@omaganap omaganap force-pushed the staging/xlnx/main-next-ad9084-dev branch from 7b4bc02 to 93ebb32 Compare January 20, 2026 20:59
@omaganap omaganap marked this pull request as ready for review January 20, 2026 21:00
@omaganap
Copy link
Copy Markdown
Author

@gastmaier , @nunojsa , I made the fixes and I added new files. Let me know if there is anything else I need to change.

@gastmaier
Copy link
Copy Markdown
Collaborator

@omaganap omaganap force-pushed the staging/xlnx/main-next-ad9084-dev branch from b7e82ea to eb02d81 Compare January 22, 2026 17:33
Add vu11p NYX dts and device tree for nyx personality card
Add new device tree file for vu11p for profile 204C_M4_L4_NP16_8p0_2x2

Signed-off-by: Oscar Magana Pantoja <Oscar.MaganaPantoja@analog.com>
@omaganap
Copy link
Copy Markdown
Author

https://stackoverflow.com/questions/30884131/remove-trailing-spaces-automatically-or-with-a-shortcut

Sorry I missed the other file I added. I also fixed the white spaces on arch/arm64/boot/dts/xilinx/vu11p-ad9084-vpx-revb.dtso since that's the one I copied the bulk of the code.

@nunojsa
Copy link
Copy Markdown
Collaborator

nunojsa commented Jan 23, 2026

It also seems CI is not passing

@omaganap
Copy link
Copy Markdown
Author

omaganap commented Jan 23, 2026

It also seems CI is not passing

Yea I looked through that check but I think the errors are in the logs are primarily related to files under arch/microblaze/boot/dts/ such as vcu118_quad_ad9081.dtsi and related dts files. Not from my changes. Maybe the CI needs to be updated/fixed?

@gastmaier
Copy link
Copy Markdown
Collaborator

Looking into the cause of the compile dts failure, not sure if caused by .dtso instead of .dts

The dts does not compile isolated, it is a template for multiple
parameters.

Signed-off-by: Jorge Marques <jorge.marques@analog.com>
The dts does not compile isolated, it is a template for multiple
parameters.

Signed-off-by: Jorge Marques <jorge.marques@analog.com>
@gastmaier
Copy link
Copy Markdown
Collaborator

gastmaier commented Jan 26, 2026

Ok gotcha, starting on apollo we have template dts, that error out by themself.

2026-01-22T17:36:44.8684741Z arch/microblaze/boot/dts/vcu118_ad9084.dts:23:2: error: #error "DEVICE_PROFILE_NAME must be defined"
2026-01-22T17:36:44.8685784Z    23 | #error "DEVICE_PROFILE_NAME must be defined"
2026-01-22T17:36:44.8686332Z       |  ^~~~~
2026-01-22T17:36:44.8687067Z arch/microblaze/boot/dts/vcu118_ad9084.dts:27:2: error: #error "OUT_CLK_SELECT must be defined"
2026-01-22T17:36:44.8688317Z    27 | #error "OUT_CLK_SELECT must be defined"
2026-01-22T17:36:44.8688836Z       |  ^~~~~
2026-01-22T17:36:44.8689699Z arch/microblaze/boot/dts/vcu118_ad9084.dts:31:2: error: #error "SYS_CLK_SELECT must be defined"
2026-01-22T17:36:44.8690678Z    31 | #error "SYS_CLK_SELECT must be defined"
2026-01-22T17:36:44.8691198Z       |  ^~~~~
2026-01-22T17:36:44.8691943Z arch/microblaze/boot/dts/vcu118_ad9084.dts:35:2: error: #error "HMC7044_PLL2_FREQ must be defined"
2026-01-22T17:36:44.8692985Z    35 | #error "HMC7044_PLL2_FREQ must be defined"
2026-01-22T17:36:44.8693506Z       |  ^~~~~

Since we have markers like

 * hdl_project: <ad9084_fmca_ebz/vcu118>
 * board_revision: <>

I will extend

 * is_template: true 

as an alternative to ci/travis/dtb_build_test_exceptions

aka

dts_files=$(grep -LE  "^[[:space:]]*\*[[:space:]]*is_template:[[:space:]]*true" $dts_files)

Yes, .dtsi stands for include, while .dts are 'final dts'
But you may define dts as "contains the board-level information". In this case, the template is more of a .dts than a .dtsi.
https://bootlin.com/pub/conferences/2021/webinar/petazzoni-device-tree-101/petazzoni-device-tree-101.pdf

NOTE: We currently are not globbing .dtso

https://github.com/analogdevicesinc/linux/blob/staging/xlnx/main-next-ad9084-dev/.github/workflows/top-level.yml#L180-L195

*
* hdl_project: <ad9084_fmca_ebz/vcu118>
* board_revision: <>
* is_template: true
Copy link
Copy Markdown
Collaborator

@nunojsa nunojsa Jan 26, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this is a big hack! Looking at the commit message:

"The dts does not compile isolated, it is a template for multiple
parameters."

AFAIK, a .dts must compile. If it's not compiling then we're doing something wrong and this feels like papering around it.

@gastmaier gastmaier merged commit 6a6701f into analogdevicesinc:staging/xlnx/main-next-ad9084-dev Jan 26, 2026
33 of 35 checks passed
@nunojsa
Copy link
Copy Markdown
Collaborator

nunojsa commented Jan 26, 2026

Ok gotcha, starting on apollo we have template dts, that error out by themself.

Again, I do not think this can happen. Fine this is merged on a dev branch but I do expect we fix this out before merging into main. Unless I'm missing something...

@gastmaier
Copy link
Copy Markdown
Collaborator

Sorry, i merged without seeing this comment, should we rename them as .dtsi?

@gastmaier
Copy link
Copy Markdown
Collaborator

This is an alternative to the ci/travis/dtb_build_test_exceptions, which has a lot I am want to clean-up

The use case is to have a "master" devicetree and children that just tune the values, like this one
https://github.com/analogdevicesinc/linux/blob/staging/xlnx/main-next-ad9084-dev/arch/microblaze/boot/dts/vcu118_ad9084_204C_M4_L8_NP16_20p0_4x2_CLL.dts

Let me know your preference:

  • Rename to .dtsi
  • Don't error out, instead, have a default value set if not defined by the children
  • use ci/travis/dtb_build_test_exceptions
  • something else

@nunojsa
Copy link
Copy Markdown
Collaborator

nunojsa commented Jan 26, 2026

Sorry, i merged without seeing this comment, should we rename them as .dtsi?

It depends, if this is just about some different configuration, I think a .dts including a .dts is fine. I think that what needs to be done is that the main/base .dts needs to compile (so it likely needs some fixing) and the extensions just change the bits they need for their usecase.

So without knowing too much detail on what is going one, at first glance, this does not look like a CI problem to me.

For reference on style:

https://elixir.bootlin.com/linux/v6.18.6/source/Documentation/devicetree/bindings/dts-coding-style.rst#L194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants