Skip to content

Conversation

@Peter-Lande
Copy link
Contributor

@Peter-Lande Peter-Lande commented Aug 12, 2025

Description

Added artifact streams.

Fixes #220

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has it been tested ?

  • Added test that posts "file.txt" and captures it in the stream.

Checklist:

  • My PR is ready for prime time! Otherwise use the "Draft PR" feature
  • All commits have a correct title
  • Readme has been updated
  • Quality tests are green (see Codacy)
  • Automated tests are green (see pipeline)

Copy link
Owner

@anancarv anancarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, this is a great feature request!
However, can you move the pyproject.toml / pre-commit updates to a separate PR?

Peter Lande added 3 commits September 7, 2025 11:15
This reverts commit 1a30044.
This reverts commit f9ec7fa.
@Peter-Lande
Copy link
Contributor Author

Removed the updates as requested and added just the stream function update.

@Peter-Lande Peter-Lande changed the title Add Artifacts Stream, Updated Pyproject.toml, and updated pre-commits. Add Artifacts Stream Sep 7, 2025
Copy link
Owner

@anancarv anancarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Peter-Lande
Copy link
Contributor Author

Okay I think I got the pre-commits working correctly now. Sorry was having issues with poetry 1.6.1 and maturin on one of my machines had to switch to a different setup. Want me to rebase or merge in master?

Copy link
Owner

@anancarv anancarv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Peter-Lande
Copy link
Contributor Author

Code check failed due to tests but they all pass (seems it is an issue with me not having a secret on my fork). Still okay to merge?

@anancarv
Copy link
Owner

Code check failed due to tests but they all pass (seems it is an issue with me not having a secret on my fork). Still okay to merge?

It is because you don't have codacy secrets on your branch, but it's ok to merge. Merging 🚀

@anancarv anancarv merged commit 9200fd0 into anancarv:master Sep 23, 2025
2 of 7 checks passed
@Peter-Lande Peter-Lande deleted the artifact-stream branch September 23, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for exposing File Streams

2 participants