-
Notifications
You must be signed in to change notification settings - Fork 57
Add Artifacts Stream #221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Artifacts Stream #221
Conversation
anancarv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, this is a great feature request!
However, can you move the pyproject.toml / pre-commit updates to a separate PR?
|
Removed the updates as requested and added just the stream function update. |
anancarv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
|
Okay I think I got the pre-commits working correctly now. Sorry was having issues with poetry 1.6.1 and maturin on one of my machines had to switch to a different setup. Want me to rebase or merge in master? |
anancarv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
|
Code check failed due to tests but they all pass (seems it is an issue with me not having a secret on my fork). Still okay to merge? |
It is because you don't have codacy secrets on your branch, but it's ok to merge. Merging 🚀 |
Description
Added artifact streams.
Fixes #220
Type of change
Please delete options that are not relevant.
How has it been tested ?
Checklist: