Skip to content

Update automotive declaration to use android:appCategory="video" and …#37

Open
jankleinert wants to merge 1 commit intomainfrom
jkleinert/automotive-video-update
Open

Update automotive declaration to use android:appCategory="video" and …#37
jankleinert wants to merge 1 commit intomainfrom
jkleinert/automotive-video-update

Conversation

@jankleinert
Copy link

…remove automotive_app_desc.xml as it's no longer needed

…remove automotive_app_desc.xml as it's no longer needed
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the application's automotive declaration by categorizing it as a video application directly within the Android Manifest. This change simplifies the project structure by eliminating a redundant XML resource previously used for automotive app descriptions, ensuring compliance with current Android Automotive OS guidelines.

Highlights

  • Android Manifest Update: The AndroidManifest.xml file was updated to explicitly declare the application's category as "video" using android:appCategory="video".
  • Automotive Metadata Removal: The tag referencing automotive_app_desc.xml was removed from AndroidManifest.xml, as it is no longer needed.
  • Deprecated XML File Removal: The automotive_app_desc.xml file, which contained the automotive app description, was completely removed from the project.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the declaration for Android Automotive OS. It replaces the legacy <meta-data> tag and its associated automotive_app_desc.xml resource file with the android:appCategory="video" attribute directly in the <application> tag of AndroidManifest.xml. This change aligns the application with current Android guidelines for automotive video apps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant