-
Notifications
You must be signed in to change notification settings - Fork 260
Remote install #168
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remote install #168
Conversation
Summary of ChangesHello @garanj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the user experience for installing the Androidify Wear OS app by shifting the installation initiation from the phone's Play Store to a direct launch on the watch. This change addresses previous friction points where users had to manually navigate the Play Store on their phone to target the watch, making the process much more efficient and user-friendly. The update also ensures a smooth transition within the phone app once the watch app is installed. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively refactors the Wear OS app installation flow to be initiated from the watch, which is a great UX improvement. The code changes are well-organized, propagating the new click handler through the UI layers to the ViewModel and repository. My review includes a few suggestions to enhance robustness and maintainability:
- I've pointed out a missing error handling case that could lead to an app crash.
- I've suggested a way to improve the user experience by allowing retries on installation failure.
- There's also a minor API design suggestion to reduce redundancy by using an already injected dependency.
Overall, this is a solid contribution. Addressing these points will make the implementation more resilient.
Modifies the Wear OS app install flow from a Play store on phone approach, to a Play store on watch approach.
Previously, tapping on the Install Androidify button in the watch face bottom sheet would launch Play on the phone. However, this is challenging as there are then a couple of steps required in order for the user to target the watch from the Play phone app.
Instead, when tapping the install button the user will now see this:
and the Play store will be opened on the watch, allowing installation to continue from there:
Once the installation has completed, the existing phone Androidify functionality detects the presence of the Wear OS app, and automatically transitions the bottom sheet to the watch face selection view.