Skip to content

build: update minSdk to 23#223

Open
Myshkouski wants to merge 1 commit intoandroid:mainfrom
Myshkouski:main
Open

build: update minSdk to 23#223
Myshkouski wants to merge 1 commit intoandroid:mainfrom
Myshkouski:main

Conversation

@Myshkouski
Copy link

Resolves #222

@google-cla
Copy link

google-cla bot commented Mar 20, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the minSdk version in the build.gradle.kts file and adds new dependencies related to UI tooling and previewing. This change ensures that the application targets a more recent Android API level and leverages the latest UI development tools.

Highlights

  • Minimum SDK Version: The minimum SDK version was updated from 21 to 23.
  • Dependencies: Added ui.tooling.preview and ui.tooling dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the minSdk to 23 and adds dependencies for Jetpack Compose tooling. The changes themselves appear correct. I've added one minor suggestion to improve the readability of the Gradle build file by grouping dependency configurations. In the future, it would be beneficial to separate unrelated changes (like a minSdk update and adding new features/dependencies) into distinct pull requests for better clarity in the project's history.

I am having trouble creating individual review comments. Click here to see my feedback.

TvMaterialCatalog/app/build.gradle.kts (62-63)

medium

For improved readability, it's a good practice to separate different dependency configurations (like implementation and debugImplementation) with a blank line. This helps in quickly distinguishing between different types of dependencies.

    implementation(libs.ui.tooling.preview)

    debugImplementation(libs.ui.tooling)

@pflammertsma
Copy link
Member

@Myshkouski Thanks for your contribution! Please follow the steps to sign a Contributor License Agreement (CLA): https://github.com/android/tv-samples/pull/223/checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Project failed to build

2 participants