Skip to content

fix(@angular/build): support TypeScript isolatedDeclarations option #32349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cexbrayat wants to merge 1 commit into from
Closed

fix(@angular/build): support TypeScript isolatedDeclarations option #32349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion packages/angular/build/src/tools/angular/compilation/angular-compilation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ export abstract class AngularCompilation {
suppressOutputPathCheck: true,
outDir: undefined,
sourceMap: false,
declaration: false,
declarationMap: false,
allowEmptyCodegenFiles: false,
annotationsAs: 'decorators',
Expand Down
4 changes: 3 additions & 1 deletion packages/angular/build/src/tools/esbuild/angular/compiler-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,9 @@ function createCompilerOptionsTransformer(
return {
...compilerOptions,
noEmitOnError: false,
composite: false,
// TypeScript requires either declaration or composite to be true when isolatedDeclarations is set
Copy link
Collaborator

@alan-agius4 alan-agius4 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will most likely slow down the build since we'd be generating declarations we don't really need for an app. Also, our current setup does handles composite projects yet.

declaration: compilerOptions.isolatedDeclarations ? compilerOptions.declaration : false,
composite: compilerOptions.isolatedDeclarations ? compilerOptions.composite : false,
inlineSources: !!pluginOptions.sourcemap,
inlineSourceMap: !!pluginOptions.sourcemap,
sourceMap: undefined,
Expand Down