refactor(@angular/build): cleanup Vitest build options utilities#32876
Open
clydin wants to merge 1 commit intoangular:mainfrom
Open
refactor(@angular/build): cleanup Vitest build options utilities#32876clydin wants to merge 1 commit intoangular:mainfrom
clydin wants to merge 1 commit intoangular:mainfrom
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the Vitest build options by extracting the logic for determining the ZoneJS testing strategy into a dedicated function and simplifying the virtual file content generation. Feedback suggests further improving the readability of the new getZoneTestingStrategy function by removing redundant else statements to flatten the logic.
packages/angular/build/src/builders/unit-test/runners/vitest/build-options.ts
Show resolved
Hide resolved
clydin
force-pushed
the
refactor/vitest-build-options
branch
from
fca6e89 to
bbb6afa
Compare
clydin
force-pushed
the
refactor/vitest-build-options
branch
from
bbb6afa to
8fc1420
Compare
Extract zone testing strategy resolution to a separate function and reduce complexity of template literals.
clydin
force-pushed
the
refactor/vitest-build-options
branch
from
8fc1420 to
4e4422c
Compare
clydin
added
the
action: review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract zone testing strategy resolution to a separate function and reduce complexity of template literals.