Skip to content

test(multiple): remove checks for popover from test #32622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crisbeto merged 1 commit into from
Jan 8, 2026
Merged

test(multiple): remove checks for popover from test #32622

crisbeto merged 1 commit into from
Jan 8, 2026

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jan 8, 2026

After #32422 all our test environments should support popovers. These changes remove some workarounds meant to handle browsers that don't support it.

@crisbeto
test(multiple): remove checks for popover from test
1068288 
After angular#32422 all our test environments should support popovers. These changes remove some workarounds meant to handle browsers that don't support it.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 8, 2026
@crisbeto crisbeto marked this pull request as ready for review January 8, 2026 13:04
@pullapprove pullapprove bot requested review from ok7sai and tjshiu January 8, 2026 13:04
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jan 8, 2026
@crisbeto crisbeto removed the request for review from ok7sai January 8, 2026 17:18
@crisbeto crisbeto merged commit 14479d4 into angular:main Jan 8, 2026
27 of 29 checks passed
@crisbeto
Copy link
Member Author

crisbeto commented Jan 8, 2026

This PR was merged into the repository. The changes were merged into the following branches:

crisbeto added a commit that referenced this pull request Jan 8, 2026
@crisbeto
test(multiple): remove checks for popover from test (#32622)
b8192d2 
After #32422 all our test environments should support popovers. These changes remove some workarounds meant to handle browsers that don't support it.

(cherry picked from commit 14479d4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tjshiu tjshiu tjshiu approved these changes

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @tjshiu