fix(material/sidenav): not resetting margin if transition does not start#33001
Open
crisbeto wants to merge 1 commit intoangular:mainfrom
Open
fix(material/sidenav): not resetting margin if transition does not start#33001crisbeto wants to merge 1 commit intoangular:mainfrom
crisbeto wants to merge 1 commit intoangular:mainfrom
Conversation
Currently the sidenav sets its margin when the transition starts, however that might not happen if its interruped which can leave it in a broken state. These changes switch to always dispatching the event. Fixes angular#32992.
crisbeto
force-pushed
the
32992/sidenav-animation-start
branch
from
82170de to
1a1dff8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the sidenav sets its margin when the transition starts, however that might not happen if its interruped which can leave it in a broken state.
These changes switch to always dispatching the event.
Fixes #32992.