fix(opencode): expose permission on session update route and expand patterns#15118
Open
jquense wants to merge 1 commit intoanomalyco:devfrom
Open
fix(opencode): expose permission on session update route and expand patterns#15118jquense wants to merge 1 commit intoanomalyco:devfrom
jquense wants to merge 1 commit intoanomalyco:devfrom
Conversation
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
de52cfb to
5d99ddb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15116
Fixes #10212
Fixes #5965
Type of change
What does this PR do?
PATCH /session/{sessionID}doesn't accept apermissionfield, even thoughPOST /sessiondoes. This adds it, and also runsexpandRuleset(resolves~/and$HOMEin patterns) in both the create and update route handlers. Without this, permission patterns passed via the API with~/or$HOMEare stored literally and never match — unlike patterns fromopencode.jsoncwhich go throughfromConfigand get expanded.Changes:
permissionto the PATCH session route validator and handlerexpandRuleset()fromPermissionNextHow did you verify your code works?
tsgo --noEmitpasses~/and$HOMEpatterns, confirmed they are expanded to the absolute home directory pathSessionUpdateDatatype includespermission?: PermissionRulesetScreenshots / recordings
N/A — no UI changes
Checklist