fix(opencode): handle client disconnect in SSE stream writes#15147
Open
zaxbysauce wants to merge 2 commits intoanomalyco:devfrom
Open
fix(opencode): handle client disconnect in SSE stream writes#15147zaxbysauce wants to merge 2 commits intoanomalyco:devfrom
zaxbysauce wants to merge 2 commits intoanomalyco:devfrom
Conversation
When running opencode serve with external clients, SSE stream writes would fail with 'Unexpected EOF' when clients disconnect abruptly. These errors were not caught, causing the server to enter a corrupted state where subsequent requests would also fail. This fix wraps all writeSSE calls in try/catch to gracefully handle client disconnects by: - Cleaning up the event subscription - Clearing the heartbeat interval - Logging the disconnection This ensures the server remains stable after client disconnects.
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
added
the
needs:compliance
Contributor
|
The following comment was made by an LLM, it may be inaccurate: I found one potentially related PR: #14092: fix(opencode): prevent resource leaks in serve/web shutdown and SSE stream cleanup This PR addresses similar resource cleanup issues in SSE stream handling and server shutdown, which is closely related to the client disconnect handling in PR #15147. Both are addressing stability and resource management in SSE operations. |
Author
|
Pull Request content has been updated to comply with PR template. |
github-actions
bot
removed
the
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #15149
Type of change
What does this PR do?
Fixes server becoming unresponsive when external clients disconnect during SSE streaming.
When running
opencode servewith external clients, if a client disconnects abruptly while connected to the/eventor/global/eventSSE endpoints, thewriteSSEcalls throw unhandled "Unexpected EOF" errors. These errors corrupt the server state, causing subsequent requests to also fail.The fix wraps all
writeSSEcalls in try/catch to gracefully handle client disconnects by cleaning up event subscriptions, clearing heartbeat intervals, and logging the disconnection.How did you verify your code works?
Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.