fix(tui): guard against undefined prompt ref in onMount#15160
Open
Humeo wants to merge 1 commit intoanomalyco:devfrom
Open
fix(tui): guard against undefined prompt ref in onMount#15160Humeo wants to merge 1 commit intoanomalyco:devfrom
Humeo wants to merge 1 commit intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #7839
Type of change
What does this PR do?
On Windows Terminal, renderer.getPalette() resolves asynchronously and triggers a setStore update in theme.tsx. This causes SolidJS to flush pending effects — including onMount in home.tsx — before the ref callback has executed, leaving prompt as undefined and crashing with "undefined is not an object (evaluating 'prompt.set')".
Added an early return guard
if (!prompt) returnin onMount to prevent calling prompt.set() before the ref is assigned.How did you verify your code works?
Ran opencode --prompt "hello" in a Docker container (Linux). No crash. The bug is Windows-specific due to async terminal palette detection, but the guard prevents the crash regardless of platform.
Screenshots / recordings
not a UI change
Checklist
If you do not follow this template your PR will be automatically rejected.