feat: un-hardcode NPM registry URL and get from npm config#22783
Open
entr0pia wants to merge 3 commits intoanomalyco:devfrom
Open
feat: un-hardcode NPM registry URL and get from npm config#22783entr0pia wants to merge 3 commits intoanomalyco:devfrom
entr0pia wants to merge 3 commits intoanomalyco:devfrom
Conversation
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Based on my search, I found two potentially related PRs:
Both PRs are related to handling npm configuration dynamically rather than hardcoding values, which aligns with the goals of PR #22783. PR #11388 specifically targets npm registry configuration, making it the most closely related. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #11387
Type of change
What does this PR do?
This PR removes hardcoded references to https://registry.npmjs.org in several core packages and scripts. Instead, it dynamically retrieves the configured NPM registry using the idiomatic bun shell ($) to execute
pm config get registry.
How did you verify your code works?
Verification steps:
pm config set registry <custom_url>.
Screenshots / recordings
N/A
Checklist