Makefile: use -march=native on x86_64 Darwin#271
Open
hexxyan wants to merge 1 commit into
Open
Conversation
Apple Clang on x86_64 macOS rejects -mcpu=native with 'unsupported option'. Use -mcpu=native only on arm64 (Apple Silicon), fall back to -march=native on x86_64 Darwin. Linux unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make cpufails on x86_64 macOS because Apple Clang rejects-mcpu=native:Fix: use
-mcpu=nativeonly onarm64Darwin (Apple Silicon), fall back to-march=nativeonx86_64Darwin. Linux behavior unchanged.What Changed
Makefile(+5 lines)Adds
UNAME_Mdetection and a nestedifeqfor Darwin:-mcpu=native(Apple Silicon, works)-march=native(Intel Mac, works)-march=native(unchanged)Verification
Before (x86_64 macOS):
After: