Open
Conversation
closes antonmedv#111 closes antonmedv#115
Author
|
@antonmedv: I have just rebased my changes to resolve the conflict after ab52adb. Friendly bump: Is there anything I can do to have this reviewed and merged? I separated all of my changes into different commits so that it is easier to review them individually. But if you’d like, I could also submit smaller PRs individually. |
Owner
|
I will take a look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for making such a nice text editor for browsers! I had deleted my GitHub account, but I created another one just to contribute to this. (So I hope it is appreciated!) You might remember me from #49
A small (but very relevant) note is that I have only tested this in Firefox, as I do not have easy access to other browsers currently. If this turns out to work poorly in Chrome or other browsers, I am willing to invest the time into resolving that!