Fixes the shell fate delete command#6051
Merged
ddanielr merged 3 commits intoapache:2.1from Feb 10, 2026
Merged
Conversation
Changes the delete action of the `shell fate --delete` to actually remove the fate transaction id from table_locks instead of looking for the zlock under the manager lock. This matches the same delete behavior as the `admin fate --delete` command
Contributor
Author
|
Looking at the code history, I'm not sure if the |
keith-turner
approved these changes
Jan 13, 2026
Contributor
keith-turner
left a comment
keith-turner
left a comment
There was a problem hiding this comment.
Did you try running these changes with a locked fate operation?
kevinrr888
approved these changes
Feb 2, 2026
Added a test for deleting table locks from a hung fate transaction
Contributor
Author
Yes and I added a test for table lock deletion |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the delete action of the
shell fate --deleteto actually remove the fate transaction id from table_locks instead of looking for the zlock under the manager lock.This matches the same delete behavior as the
admin fate --deletecommandRelates to #6044 as this was discovered during attempts to consolidate the server zlock deletion code.