feat(#1797): add message delivery tracking to QueueMessageReference#1796
Open
jeanouii wants to merge 1 commit intoapache:mainfrom
Open
feat(#1797): add message delivery tracking to QueueMessageReference#1796jeanouii wants to merge 1 commit intoapache:mainfrom
jeanouii wants to merge 1 commit intoapache:mainfrom
Conversation
Add isDelivered()/setDelivered() to QueueMessageReference interface with implementations in IndirectMessageReference (boolean field) and NullMessageReference (no-op). PrefetchSubscription.acknowledge() now marks messages as delivered=true when processing DeliveredAck, enabling downstream consumers to distinguish delivered-but-unacked messages.
jeanouii
changed the title
jbonofre
reviewed
Mar 18, 2026
| private boolean dropped; | ||
| /** Has the message been acked? */ | ||
| private boolean acked; | ||
| /** Has the message been acked? */ |
Member
There was a problem hiding this comment.
The javadoc doesn't seem correct to me. I think it's a copy from acked javadoc.
Suggested change
| /** Has the message been acked? */ | |
| /** Has the message been delivered? */. |
| } | ||
|
|
||
| @Override | ||
| public boolean isDelivered() { |
Member
There was a problem hiding this comment.
I guess it should be synchronized.
Suggested change
| public boolean isDelivered() { | |
| public synchronized boolean isDelivered() { |
| return delivered; | ||
| } | ||
|
|
||
| public void setDelivered(final boolean delivered) { |
Member
There was a problem hiding this comment.
I guess it should be synchronized.
Suggested change
| public void setDelivered(final boolean delivered) { | |
| public synchronized void setDelivered(final boolean delivered) { |
| return delivered; | ||
| } | ||
|
|
||
| public void setDelivered(final boolean delivered) { |
Member
There was a problem hiding this comment.
@Override seems missing here.
Suggested change
| public void setDelivered(final boolean delivered) { | |
| @Override | |
| public void setDelivered(final boolean delivered) { |
| } | ||
|
|
||
| int index = 0; | ||
| for (Iterator<MessageReference> iter = dispatched.iterator(); iter.hasNext(); index++) { |
Member
There was a problem hiding this comment.
It seems this loop overrides what has been done in the previous loop (line 275). Maybe we should merge the logic in one loop ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add isDelivered()/setDelivered() to QueueMessageReference interface with implementations in IndirectMessageReference (boolean field) and NullMessageReference (no-op). PrefetchSubscription.acknowledge() now marks messages as delivered=true when processing DeliveredAck, enabling downstream consumers to distinguish delivered-but-unacked messages.