You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
FastAPI 0.137.0's lazy router inclusion breaks api-server and dag-processor startup in two ways: the execution API health route used @router.get("") under prefix="/health", which now raises Prefix and path cannot be both empty, and
Cadwyn's versioned router generation is not yet compatible with FastAPI 0.137.0.
Cap fastapi<0.137.0, with uv.lock synced, to restore startup while waiting for Cadwyn compatibility.
Change the execution API health routes to explicit paths (/health, /health/ping) so they remain valid once the cap is lifted. External paths are unchanged.
Add a regression test to prevent reintroducing an empty health route path.
Was generative AI tooling used to co-author this PR?
I believe Cadwyn 7.1.0 has now support for 0.137.1+ -> I think we should bring it back @Revanth14 ?
Thanks for the heads-up @potiuk. I checked Cadwyn 7.1.0 and it now declares fastapi>=0.137.1, so I agree we can remove the temporary fastapi<0.137.0 cap.
I’ll open a follow-up PR to bump Cadwyn to >=7.1.0, relax FastAPI to >=0.137.1, refresh uv.lock, and run the relevant API/versioned-router regression tests.
@potiuk@shahar1 : bumped Cadwyn to >=7.1.0 and FastAPI to >=0.137.1. Heads-up that the bump surfaced a second 0.137 incompatibility beyond the empty-path fix: lazy router inclusion freezes a router's dependencies at include_router() time, so the execution API's OTel trace-context dependency (injected after assembly) was being dropped. Reworked the router assembly into a build-time factory to fix it, preserving the unsafe-always / only-authenticated / never ordering. Full execution-API suite (480 tests) green, would appreciate a look when you have a moment.
Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #68562
FastAPI 0.137.0's lazy router inclusion breaks api-server and dag-processor startup in two ways: the execution API health route used
@router.get("")underprefix="/health", which now raisesPrefix and path cannot be both empty, andCadwyn's versioned router generation is not yet compatible with FastAPI 0.137.0.
fastapi<0.137.0, withuv.locksynced, to restore startup while waiting for Cadwyn compatibility./health,/health/ping) so they remain valid once the cap is lifted. External paths are unchanged.Was generative AI tooling used to co-author this PR?