Skip to content

Fix race condition on sort param when returning dagRuns#68842

Open
HasnainRaz wants to merge 2 commits into
apache:mainfrom
HasnainRaz:fix-race-on-get-dagRuns
Open

Fix race condition on sort param when returning dagRuns#68842
HasnainRaz wants to merge 2 commits into
apache:mainfrom
HasnainRaz:fix-race-on-get-dagRuns

Conversation

@HasnainRaz

@HasnainRaz HasnainRaz commented Jun 22, 2026

Copy link
Copy Markdown

I have a use case where I continously poll the GET: /api/v2/dags/{dag_id}/dagRuns endpoint with a sort parameter defined. The response of the endpoint is fine, but once in a couple of hours, it will return the wrong ordering.

I traced it to this change in the PR, essentially, the instantiated object state is mutated if there is a race condition between two requests with different sort parameters, leading to incorrect results for one of the requests.


Was generative AI tooling used to co-author this PR?
  • Yes (please specify the tool below)

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@boring-cyborg boring-cyborg Bot added the area:API Airflow's REST/HTTP API label Jun 22, 2026
@boring-cyborg

boring-cyborg Bot commented Jun 22, 2026

Copy link
Copy Markdown

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example Dag that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better 🚀.
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:API Airflow's REST/HTTP API

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant