Skip to content

Fix mypy type errors in DynamoDB example system test#68849

Open
23tae wants to merge 1 commit into
apache:mainfrom
23tae:feat/fix-dynamodb-type-hints
Open

Fix mypy type errors in DynamoDB example system test#68849
23tae wants to merge 1 commit into
apache:mainfrom
23tae:feat/fix-dynamodb-type-hints

Conversation

@23tae

@23tae 23tae commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

This PR resolves the mypy [arg-type] error in the DynamoDB example system test.

Description

The type error occurred because task variables (create_table, delete_table) shadowed the helper function names. This confused mypy's type inference when passing these variables to chain().

Key changes

  • Renamed the shadowed task variables to create_table_task and delete_table_task.
  • Removed the obsolete # TODO: FIXME and # mypy: disable-error-code="arg-type" comments.

Verification Results

I have verified the changes locally:

  • Static Checks (Prek): Passed
  • Unit Tests (Breeze): Passed

  • Read the Pull Request Guidelines for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
  • For fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
  • When adding dependency, check compliance with the ASF 3rd Party License Policy.
  • For significant user-facing changes create newsfragment: {pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.

@23tae 23tae requested a review from o-nikolas as a code owner June 22, 2026 16:02
@boring-cyborg boring-cyborg Bot added area:providers provider:amazon AWS/Amazon - related issues labels Jun 22, 2026
@vincbeck

Copy link
Copy Markdown
Contributor

Seems to not be working

@23tae

23tae commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

Seems to not be working

Rebased on main to pull in #68857, which fixes the unrelated mypy error in login.py. The mypy checks are passing cleanly now.
@vincbeck Just to clarify, was your comment regarding the CI failures, or is something else not working?

@23tae 23tae force-pushed the feat/fix-dynamodb-type-hints branch from 0ea9961 to 9a6d119 Compare June 23, 2026 01:32
@23tae 23tae force-pushed the feat/fix-dynamodb-type-hints branch from 9a6d119 to 8d04395 Compare June 23, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:providers provider:amazon AWS/Amazon - related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants