Fix AwsBatchExecutor test_try_adopt_task_instances after TaskInstanceDTO hostname requirement#68871
Merged
vatsrahul1001 merged 1 commit intoJun 23, 2026
Conversation
…DTO hostname requirement apache#68027 routes orphaned-task adoption through TaskInstanceDTO.model_validate, and TaskInstanceDTO inherits a required hostname: str field from the SDK TaskInstance. The test's mock.Mock(spec=TaskInstance) never set .hostname, so model_validate received a Mock and raised a pydantic string_type ValidationError. This fails on main today (Non-DB / LowestDeps / LatestBoto / Pendulum2 provider jobs). Set task.hostname on the orphaned-task mocks so the DTO validates. Verified locally: 1 passed.
boring-cyborg
Bot
added
area:providers
provider:amazon
23tae
approved these changes
Jun 23, 2026
vatsrahul1001
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
set
task.hostnameon the orphaned-task mocks so the DTO validates.Verified locally (breeze, py3.10):
test_try_adopt_task_instancesnow passes (1 passed); previously failed with ValidationErrorrelated: #68027