AMBARI-26546: Disable hostname verifier in ExecutionScheduleManager#4073
Open
develop-vijay wants to merge 1 commit intoapache:trunkfrom
Open
AMBARI-26546: Disable hostname verifier in ExecutionScheduleManager#4073develop-vijay wants to merge 1 commit intoapache:trunkfrom
develop-vijay wants to merge 1 commit intoapache:trunkfrom
Conversation
Contributor
|
@develop-vijay I suggest add comments in the code to explain the intent of this code, why it's commented out instead of deleted, and include logging to facilitate future problem investigation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When SSL is enabled for Ambari, And batch restart request is triggered(Service level slave component restarts. Example datanode rolling restart), Batch execution is failed except for the 1st batch. This is because in a SSL enabled environment, When hitting localhost, hostname verification is failing.
Proposed Fix: Hostname verification is not required for internal API call. It was already disabled in previous versions of Ambari, As part of JDK 17 support, This code was commented out
How was this patch tested?
Applied the fix in SSL enabled enviroment and verified its working.
Please review Ambari Contributing Guide before opening a pull request.