fix: throw on schema mismatch in RecordBatchStreamWriter.write()#389
Open
rustyconover wants to merge 1 commit intoapache:mainfrom
Open
fix: throw on schema mismatch in RecordBatchStreamWriter.write()#389rustyconover wants to merge 1 commit intoapache:mainfrom
rustyconover wants to merge 1 commit intoapache:mainfrom
Conversation
Previously, writing a RecordBatch with a mismatched schema to a writer with autoDestroy=true (the default) would silently close the writer and drop the batch, causing data loss with no error or warning. Now throws an Error with both the expected and received schemas, making the mismatch immediately visible to the caller. Closes apache#388 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecordBatchStreamWriter.write()previously silently closed the writer and dropped the batch when a schema mismatch was detected withautoDestroy: true(the default), causing data loss with no errorErrorwith both expected and received schemas, making mismatches immediately visibleautoDestroyoption explaining its behaviorTest plan
schema-mismatch-tests.tswith 4 tests covering:autoDestroy=true: throws on schema mismatchautoDestroy=false: resets schema and writes multi-stream output (existing behavior preserved)npx jest --testPathPattern='schema-mismatch')Closes #388
🤖 Generated with Claude Code