GH-48664: [R] Implement support for keepNA = FALSE in base::nchar() #48665
+22
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
HyukjinKwon
force-pushed
the
GH-48664
branch
from
860f92b to
7cc044b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Should address TODO added in commit 81e1fbc (ARROW-17665)
arrow/r/R/dplyr-funcs-string.R
Line 488 in 744f0ec
Implemented the argument intended to work.
What changes are included in this PR?
This PR Implement support for
keepNA = FALSEinbase::nchar()Are these changes tested?
Unittest was added.
Are there any user-facing changes?
Yes. Now
nchar(..., keepNA = FALSE)should work.