GH-49537: [C++][FlightRPC] Windows CI to Support ODBC DLL & MSI Signing by alinaliBQ · Pull Request #49603 · apache/arrow

alinaliBQ · 2026-03-26T22:54:18Z

Rationale for this change

What changes are included in this PR?

Implement Windows CIs to:
1. CI A - odbc-msvc-upload-dll Upload unsigned DLL
2. CI B - odbc-msvc-upload-msi Download signed DLL and upload unsigned MSI
Remove odbc-release CI that is replaced by the new CIs.
Use composite action to reuse code for building ODBC Windows.
The release manager can run CI A first, then download the unsigned DLL and upload signed DLL.
Run CI B to upload unsigned MSI. Then sign the MSI locally, and upload signed MSI to GitHub release. Example Command to trigger CI B:

gh workflow run cpp_extra.yml --ref apache-arrow-test-24.0.0-rc0 -f odbc_release_step=true

Example of 07-flightsqlodbc-upload.sh script (not tested):
We need to either 1) implement a way to get RUN_ID and then call gh run watch,
or 2) enter each command manually and wait for the CI to finish.

# download unsigned DLL
gh release download $tag --pattern arrow_flight_sql_odbc_unsigned.dll

# sign ODBC DLL and upload to GitHub release
jsign arrow_flight_sql_odbc_unsigned.dll ...
mv arrow_flight_sql_odbc_unsigned.dll arrow_flight_sql_odbc.dll
gh release upload $tag --clobber arrow_flight_sql_odbc.dll

# trigger CI B
gh workflow run cpp_extra.yml --ref $tag -f odbc_upload=msi

# download unsigned MSI
gh release download $tag --pattern Apache-Arrow-Flight-SQL-ODBC-*-win64.msi

# sign ODBC MSI and upload to GitHub release
jsign Apache-Arrow-Flight-SQL-ODBC-*-win64.msi ...
gh release upload $tag --clobber Apache-Arrow-Flight-SQL-ODBC-*-win64.msi

# remove ODBC DLLs from GitHub release
gh release delete-asset $tag arrow_flight_sql_odbc_unsigned.dll --yes
gh release delete-asset $tag arrow_flight_sql_odbc.dll --yes

Are these changes tested?

The uploading and signing process is tested in my repo
Workflows are verified in CI

Are there any user-facing changes?

N/A

GitHub Issue: [C++][FlightRPC][ODBC] Add CI steps to support Windows DLL and MSI signing #49537

* Add draft code for CI A and CI B Attempt workflow dispatch Only ODBC Windows original workflow should run. Later need to add `github.event_name != 'workflow_dispatch' ||` to all existing workflows after uncomment Use `GITHUB_REF_NAME` directly via push Add `workflow_dispatch` definitions Add `ODBC Windows Upload DLL` Use common ODBC Windows environment variables Use ODBC as composite action Create cpp_odbc.yml Initial draft temp disable test step Temp disable non-ODBC Windows workflows * Clean Up Code * Remove comments * Fix Installer path for MSI

alinaliBQ · 2026-03-26T23:01:50Z

.github/workflows/cpp_extra.yml

+      - name: Upload the artifacts to GitHub Release
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          gh release upload ${GITHUB_REF_NAME} \
+            --clobber \
+            arrow_flight_sql_odbc_unsigned.dll


Since both DLL and MSI need to be signed and unsigned DLL is harder to catch, uploading as arrow_flight_sql_odbc_unsigned.dll to make it clear on GitHub release if the DLL is unsigned.

alinaliBQ · 2026-03-27T17:35:07Z

@amoeba PR is ready for review. We have an issue for flight-sql-tests ODBC Windows failure: #49465

alinaliBQ · 2026-03-27T22:34:19Z

I did an empty commit (a522393) and got this error:

Error: D:\a\arrow\arrow\./.github/actions/odbc-windows\action.yml (Line: 71, Col: 12): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN
Error: GitHub.DistributedTask.ObjectTemplating.TemplateValidationException: The template is not valid. D:\a\arrow\arrow\./.github/actions/odbc-windows\action.yml (Line: 71, Col: 12): Unrecognized named-value: 'secrets'. Located at position 1 within expression: secrets.GITHUB_TOKEN
   at GitHub.DistributedTask.ObjectTemplating.TemplateValidationErrors.Check()
   at GitHub.Runner.Worker.ActionManifestManagerLegacy.ConvertRuns(IExecutionContext executionContext, TemplateContext templateContext, TemplateToken inputsToken, String fileRelativePath, MappingToken outputs)
   at GitHub.Runner.Worker.ActionManifestManagerLegacy.Load(IExecutionContext executionContext, String manifestFile)
Error: Failed to load D:\a\arrow\arrow\./.github/actions/odbc-windows\action.yml

The same implementation worked yesterday (see https://github.com/apache/arrow/actions/runs/23622018872/job/68803175375). Seems that GitHub might have updated runner, I will look into this.

alinaliBQ · 2026-03-27T22:48:57Z

Error: Failed to load D:\a\arrow\arrow./.github/actions/odbc-windows\action.yml

This issue should be resolved now by commit 95bc75b

alinaliBQ · 2026-03-31T18:40:18Z

@kou @raulcd This PR is ready for review. Please have a look if you have a chance, thank you

.github/workflows/cpp_extra.yml

amoeba · 2026-04-01T00:00:12Z

.github/workflows/cpp_extra.yml

+    needs: check-labels
+    name: ODBC Windows Upload Unsigned DLL
+    runs-on: windows-2022
+    if: inputs.odbc_upload == 'dll'


Suggested change

if: inputs.odbc_upload == 'dll'

if: inputs.odbc_release_step == 'dll'

.github/workflows/cpp_extra.yml

Change `odbc-msvc-upload-dll` to be triggered via rc tag and can be invoked manually

alinaliBQ

Addressed comments. Please have another look, thanks!

.github/workflows/cpp_extra.yml

alinaliBQ · 2026-04-02T22:06:56Z

.github/workflows/cpp_extra.yml

+    needs: check-labels
+    name: ODBC Windows Upload Unsigned DLL
+    runs-on: windows-2022
+    if: inputs.odbc_upload == 'dll'


amoeba

Thanks @alinaliBQ.

@raulcd do you want to have a look? Once we merge, I'll test the whole flow with the script (PR to come) that does the signing so we'll have more chances to fix any issues.

raulcd

Thanks for the work @alinaliBQ ! I am unsure this is ready yet, sorry it took me a couple days for review, it was Easter and had some family around. My main concern is around, the tag hasn't been updated to match the one on the packaging linux jobs, currently any tag will trigger the job and we only want to do it for RC's. The worlflow dispatch is still around and I thought this was not necessary with the tag.
@amoeba I am about to do the feature freeze, I think this is going to miss 24.0.0, is that ok?

raulcd · 2026-04-07T07:40:40Z

.github/workflows/cpp_extra.yml

  schedule:
    - cron: |
        0 0 * * *
+  workflow_dispatch:


I am not sure I understand this. Didn't we agreed to use the tag for the RC? Why is the workflow dispatch needed and referenced below?

The flow is a bit complicated, we need to trigger some jobs when the RC is created but the odbc-msvc-upload-msi step needs to be triggered manually so we use workflow_dispatch. The sequence is,

Release manager tags release

cpp_extra.yml jobs odbc-msvc-upload-dll and odbc-dll-release are run automatically, unsigned DLL is added to release

Release manager locally runs script (TBD) that downloads, signs (w/ jsign), and uploads the signed DLL to the release

Release manager triggers odbc-msvc-upload-msi via workflow_dispatch which builds an unsigned MSI with a signed DLL inside and adds it to the release

Release manager locally runs script that downloads signs (w/ jsign), and uploads the signed MSI to the releasee

I see, I did not understood the process. As the process isn't entirely automated and it requires several manual steps, can we document it on the release page?
https://github.com/apache/arrow/blob/main/docs/source/developers/release.rst

@amoeba Could you kindly help with the documentation on release page?

Absolutely. I'll file an issue and fill it in as we finish the final PRs.

amoeba · 2026-04-07T18:30:48Z

Thanks for taking a look @raulcd. It's okay if this doesn't make it for 24 but if it's at all possible that'd be great.

Re: the jobs running on any tag, I'm not seeing what you see, could you point out which job needs updating?

odbc-msvc: Runs as normal (when labeled with "Extra" label). This is the pre-existing CI for the driver.
odbc-msvc-upload-dll: Only runs when ref matches an RC tag and correctly doesn't run on workflow_dispatch
odbc-dll-release: Only runs after odbc-msvc-upload-dll
odbc-msvc-upload-msi: Only runs on workflow_dispatch

I could see making the last one (odbc-msvc-upload-msi) more defensive.

alinaliBQ · 2026-04-07T18:55:10Z

I am unsure this is ready yet, sorry it took me a couple days for review, it was Easter and had some family around. My main concern is around, the tag hasn't been updated to match the one on the packaging linux jobs, currently any tag will trigger the job and we only want to do it for RC's.

No worries @raulcd, hope you had a good Easter.
odbc-msvc-upload-dll is the job that is only triggered by RC tags. It does a if check to make sure the tag contains -rc:

     ${{ 
        startsWith(github.ref_name, 'apache-arrow-') && 
        contains(github.ref_name, '-rc') && 
        !inputs.odbc_release_step 
      }}

Since having a tags: section will impact all jobs in the cpp_extra.yml file, I used the if statement approach to the job odbc-msvc-upload-dll.

github-actions bot added CI: Extra: C++ Run extra C++ CI awaiting review Awaiting review labels Mar 26, 2026

alinaliBQ mentioned this pull request Mar 26, 2026

[C++][FlightRPC][ODBC] Add CI steps to support Windows DLL and MSI signing #49537

Open

alinaliBQ requested a review from amoeba March 26, 2026 22:56

alinaliBQ commented Mar 26, 2026

View reviewed changes

github-actions bot added awaiting committer review Awaiting committer review and removed awaiting review Awaiting review labels Mar 26, 2026

alinaliBQ marked this pull request as ready for review March 27, 2026 17:35

alinaliBQ requested review from assignUser, jonkeane, kou and raulcd as code owners March 27, 2026 17:35

Trigger CI

a522393

Fix issue with secrets.GITHUB_TOKEN

95bc75b

amoeba reviewed Apr 1, 2026

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting committer review Awaiting committer review labels Apr 1, 2026

alinaliBQ added 2 commits April 2, 2026 15:00

Change odbc_msi_upload to boolean input

9ccebbc

Change `odbc-msvc-upload-dll` to be triggered via rc tag and can be invoked manually

Work on Bryce's code review comments

20fefd5

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 2, 2026

alinaliBQ commented Apr 2, 2026

View reviewed changes

amoeba approved these changes Apr 4, 2026

View reviewed changes

raulcd reviewed Apr 7, 2026

View reviewed changes

github-actions bot removed the awaiting change review Awaiting change review label Apr 7, 2026

github-actions bot added the awaiting changes Awaiting changes label Apr 7, 2026

amoeba mentioned this pull request Apr 7, 2026

[Release][FlightSQLODBC] Create release script for signing Windows DLL and MSI #49686

Open

	if: inputs.odbc_upload == 'dll'
	if: inputs.odbc_release_step == 'dll'

Conversation

alinaliBQ commented Mar 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ commented Mar 27, 2026

Uh oh!

alinaliBQ commented Mar 27, 2026

Uh oh!

alinaliBQ commented Mar 27, 2026

Uh oh!

alinaliBQ commented Mar 31, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amoeba left a comment

Choose a reason for hiding this comment

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

amoeba commented Apr 7, 2026

Uh oh!

alinaliBQ commented Apr 7, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alinaliBQ commented Mar 26, 2026 •

edited

Loading