Skip to content

GH-49433: [C++] Buffer ARROW_LOG output to prevent thread interleaving #49663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shockp wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Open

GH-49433: [C++] Buffer ARROW_LOG output to prevent thread interleaving #49663

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cpp/src/arrow/util/logging.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@
#endif
#include <cstdlib>
#include <iostream>
#include <sstream>

#ifdef ARROW_USE_GLOG

Expand Down Expand Up @@ -67,7 +68,7 @@ class CerrLog {

virtual ~CerrLog() {
if (has_logged_) {
std::cerr << std::endl;
std::cerr << buffer_.str() << std::endl;
}
if (severity_ == ArrowLogLevel::ARROW_FATAL) {
PrintBackTrace();
Expand All @@ -77,21 +78,22 @@ class CerrLog {

std::ostream& Stream() {
has_logged_ = true;
return std::cerr;
return buffer_;
}

template <class T>
CerrLog& operator<<(const T& t) {
if (severity_ != ArrowLogLevel::ARROW_DEBUG) {
has_logged_ = true;
std::cerr << t;
buffer_ << t;
}
return *this;
}

protected:
const ArrowLogLevel severity_;
bool has_logged_;
std::ostringstream buffer_;

void PrintBackTrace() {
#ifdef ARROW_WITH_BACKTRACE
Expand Down