Skip to content

Conversation

@slfan1989
Copy link
Contributor

@slfan1989 slfan1989 commented Feb 10, 2026

Which issue does this PR close?

Closes #2001

Rationale for this change

Upgrade the Rust nightly toolchain to incorporate compiler improvements, bug fixes, and optimizations from the past 45 days (2025-05-09 to 2025-12-15).

What changes are included in this PR?

  • Update rust-toolchain.toml: nightly-2025-05-09nightly-2025-12-15
  • All components (rust-src, cargo, rustfmt, clippy) remain unchanged

Are there any user-facing changes?

No.

How was this patch tested?

CI pipeline verification

@slfan1989
Copy link
Contributor Author

@cxzl25 @richox Could you please review this PR? Thanks a lot!

@cxzl25
Copy link
Contributor

cxzl25 commented Feb 11, 2026

I remember that using nightly-2025-06-20 would cause JVM crash. I am not sure if it has been fixed now.

#1126

@slfan1989
Copy link
Contributor Author

I remember that using nightly-2025-06-20 would cause JVM crash. I am not sure if it has been fixed now.

#1126

@cxzl25 Thank you so much for the reply! I tried searching for it, but couldn’t find any information about a JVM crash caused on 2025-06-20. However, Iceberg-Rust is already using 2025-06-23. Should we give it a try?

https://github.com/apache/iceberg-rust/blob/main/rust-toolchain.toml

@richox
Copy link
Contributor

richox commented Feb 11, 2026

i suggest to use a more recent nightly version (if it works)

@slfan1989
Copy link
Contributor Author

i suggest to use a more recent nightly version (if it works)

Thanks for the suggestion! I’ll try a more recent nightly version.

@slfan1989 slfan1989 changed the title [AURON #2001] Upgrade Rust nightly toolchain to 2025-06-23. [AURON #2001] Upgrade Rust nightly toolchain to 2025-12-15. Feb 11, 2026
Signed-off-by: slfan1989 <slfan1989@apache.org>
@slfan1989
Copy link
Contributor Author

@cxzl25 @richox Based on our testing, we can upgrade to a newer version. Would it be okay to use the 2025-12-15 release?

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR upgrades the Rust nightly toolchain from nightly-2025-05-09 to nightly-2025-12-15 and applies automatic code refactorings enabled by newer Rust compiler features. The upgrade incorporates compiler improvements, bug fixes, and new language features including let-chains and improved standard library APIs.

Changes:

  • Updated Rust nightly toolchain version in rust-toolchain.toml
  • Refactored nested if-let statements to use let-chain syntax for improved readability
  • Replaced manual clone operations with std::slice::from_ref for better performance
  • Updated compiler intrinsics to use new const generic syntax for prefetch_read_data and prefetch_write_data
  • Replaced manual bit rotation with rotate_left method
  • Removed unused vec_into_raw_parts feature flag
  • Applied clippy suggestions for removing unnecessary parentheses

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
rust-toolchain.toml Updated toolchain version from nightly-2025-05-09 to nightly-2025-12-15
parquet_sink_exec.rs Removed unnecessary parentheses in send call
orc_exec.rs Refactored nested if-let statements to use let-chain syntax
generate_exec.rs Replaced clone with std::slice::from_ref
debug_exec.rs Replaced clone with std::slice::from_ref
execution_context.rs Refactored nested if-let statements to use let-chain syntax
cached_exprs_evaluator.rs Refactored nested if-let statements to use let-chain syntax
agg_exec.rs Removed unnecessary parentheses and replaced modulo check with is_multiple_of
agg_table.rs Refactored nested if-let statements to use let-chain syntax
acc.rs Refactored nested if-let statements to use let-chain syntax
spark_strings.rs Refactored nested if-let statements to use let-chain syntax
spark_get_json_object.rs Refactored nested if-let statements to use let-chain syntax
spark_dates.rs Improved formatting of multi-line expression
spark_hash.rs Replaced clone with std::slice::from_ref in tests
lib.rs Removed vec_into_raw_parts feature and updated prefetch intrinsics to use const generic syntax
ipc_compression.rs Replaced clone with std::slice::from_ref in tests
batch_serde.rs Replaced clone with std::slice::from_ref in tests
xxhash.rs Replaced manual bit rotation with rotate_left method
spill.rs Refactored nested if-let statements to use let-chain syntax

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.


[toolchain]
channel = "nightly-2025-05-09"
channel = "nightly-2025-12-15"
Copy link

Copilot AI Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states the upgrade is for "the past 45 days (2025-05-09 to 2025-12-15)", but the time span from May 9 to December 15, 2025 is approximately 220 days (about 7 months), not 45 days. Additionally, the linked issue #2001 mentions upgrading to "nightly-2025-06-23" (which would indeed be about 45 days from May 9), but the actual version being used here is "nightly-2025-12-15". Please verify which version is intended and correct the PR description accordingly.

Copilot uses AI. Check for mistakes.
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…ct.rs

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade Rust nightly toolchain to 2025-12-15

3 participants