AVRO-4071: put the recorde schema to the context after adding the fields#3206
Closed
andreabettich wants to merge 1 commit intoapache:mainfrom
andreabettich:main
Closed
AVRO-4071: put the recorde schema to the context after adding the fields#3206andreabettich wants to merge 1 commit intoapache:mainfrom andreabettich:main
andreabettich wants to merge 1 commit intoapache:mainfrom
andreabettich:main
Conversation
Contributor
|
This change causes other issues. I'm closing this PR in favour of #3304, as that contains the same change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
(For example: This pull request improves file read performance by buffering data, fixing AVRO-XXXX.)
This pull request fixes the behavior when adding two records with the same name and namespace.
As described in the Jira-Issue, the existing schema and the current one weren't compared correctly so it was never possible to add two identical records.
Verifying this change
Haven't added tests yet but can provide some to verify the change.
Documentation
No documentation needed