[Iceberg AddFiles] Attach name-mapping to table#38189
[Iceberg AddFiles] Attach name-mapping to table#38189ahmedabu98 wants to merge 2 commits intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Iceberg table management logic to automatically attach a name mapping to tables if one is not already defined. By forcing name-based resolution, it ensures better interoperability with legacy Parquet files that do not contain explicit schema-id mappings, thereby preventing potential read failures in downstream engines. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
chamikaramj
left a comment
There was a problem hiding this comment.
Thanks. LGTM.
Let's add a test please.
|
Added to existing tests |
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Helps engines to read legacy parquet files that don't have schema-id mapping present.