Add support for Apache Flink 2.1.3#38961
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces support for Apache Flink 2.1.3 within the project. It involves adding the necessary build modules for the Flink 2.1 runner, updating global configuration files to recognize the new version, and ensuring that various SDKs and test suites are correctly configured to support this update. The changes ensure that Flink 2.1 is treated as a first-class citizen alongside previous versions. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds support for Flink 2.1 by introducing the Flink 2.1 runner build configurations and updating supported version lists across properties, documentation, and SDKs. The review feedback points out that the capability resolution strategy for lz4-java in the build files should explicitly select the at.yawk.lz4 variant rather than relying on selectHighestVersion(), which might select an incompatible version. Additionally, the default parallelism in the test configuration is set to '23', which is likely a typo for '2' and could cause resource exhaustion during local test execution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| configurations.all { | ||
| resolutionStrategy.capabilitiesResolution.withCapability('org.lz4:lz4-java') { | ||
| selectHighestVersion() | ||
| } | ||
| } |
There was a problem hiding this comment.
Using selectHighestVersion() might not guarantee that Flink's preferred at.yawk.lz4:lz4-java is selected if org.lz4:lz4-java has a higher version number. To ensure the Flink-compatible version is strictly preferred, we can explicitly find and select the candidate from at.yawk.lz4.
configurations.all {
resolutionStrategy.capabilitiesResolution.withCapability('org.lz4:lz4-java') {
def candidate = candidates.find { it.id.toString().contains('at.yawk.lz4') }
if (candidate != null) {
select(candidate)
} else {
selectHighestVersion()
}
}
}
ddebowczyk92
force-pushed
the
flink-2.1-support
branch
from
a877f3f to
63d6984
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #38961 +/- ##
=========================================
Coverage 57.76% 57.77%
Complexity 13027 13027
=========================================
Files 2512 2512
Lines 261056 261076 +20
Branches 10722 10722
=========================================
+ Hits 150810 150834 +24
+ Misses 104525 104521 -4
Partials 5721 5721
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Explicitly prefer Flink's at.yawk.lz4:lz4-java over org.lz4:lz4-java to ensure the Flink-compatible version is always selected, regardless of version numbers. This is more robust than selectHighestVersion() which could theoretically select org.lz4 if it had a higher version number.
ddebowczyk92
force-pushed
the
flink-2.1-support
branch
from
63d6984 to
9429a28
Compare
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
1 participant
Adds support for Apache Flink 2.1.3
addresses #38947
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.